mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 17:32:41 +01:00
8fe27800fc
Summary: Fixes T4917. Currently, if a user doesn't have access to, e.g., Phriction, they still get a checkbox in the search results to search for Wiki Documents. Those results will be filtered anyway, so this is confusing at best. Instead, bind PHID types to applications. This is a relatively tailored fix; some areas for potential future work: - Go through every PHID type and bind them all to applications. Vaguely nice to have, but doesn't get us anything for now. - If no searchable application is installed, we don't show you an error state. This isn't currently possible ("People" is always installed) but in the interest of generality we could throw an exception or something at least. - The elasticserach thing could probably constrain types to visible types, but we don't have a viewer there easily right now. Test Plan: Uninstalled Phriction, saw the checkbox vanish. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4917 Differential Revision: https://secure.phabricator.com/D8904 |
||
|---|---|---|
| .. | ||
| PhabricatorRepositoryPHIDTypeArcanistProject.php | ||
| PhabricatorRepositoryPHIDTypeCommit.php | ||
| PhabricatorRepositoryPHIDTypeMirror.php | ||
| PhabricatorRepositoryPHIDTypePushEvent.php | ||
| PhabricatorRepositoryPHIDTypePushLog.php | ||
| PhabricatorRepositoryPHIDTypeRepository.php | ||