epriestley 09ecf49ee4 (stable) Require commit identities when editing commits to resolve an issue with audit actions not applying properly ... Summary: See <https://discourse.phabricator-community.org/t/cannot-audit-a-git-commit/2848>. In D20581, I made some audit behavior dependent upon identities, but the actual edit flow doesn't load them. This can cause us to raise an "attach identities first" exception in the bowels of the edit workflow and trigger unexpected behavior at top level. Load identities when editing a commit so that the transaction flows have access to identity information and can use it to figure out if a user is an author, etc. Test Plan: - As an auditor, applied an "Accept Commit" action to an open audit after D20581. - Before patch: accept no-ops internally since the preconditions throw. - After patch: accept works properly. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20612		2019-06-24 10:50:48 -07:00
..
__tests__	Use PhutilClassMapQuery instead of PhutilSymbolLoader	2015-08-14 07:49:01 +10:00
aphront	Fix a looping workflow when trying to submit a partially-effectless transaction group	2019-05-23 19:16:17 -07:00
applications	(stable) Require commit identities when editing commits to resolve an issue with audit actions not applying properly	2019-06-24 10:50:48 -07:00
docs	Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"	2019-06-18 11:37:14 -07:00
extensions
infrastructure	(stable) Promote 2019 Week 25	2019-06-22 07:37:36 -07:00
view	Prevent editing and deleting comments in locked conversations	2019-05-23 19:04:55 -07:00
__phutil_library_init__.php
__phutil_library_map__.php	Modularize PhabricatorEditEngineConfigurationTransaction	2019-06-20 16:25:21 -07:00