mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 17:32:41 +01:00
a49fec39be
Summary: Ref T2222. Makes the "lint/unit errors" warnings work again. Test Plan: Viewed some revisions with and without these warnings. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8475
257 lines
6.9 KiB
PHP
257 lines
6.9 KiB
PHP
<?php
|
|
|
|
final class DifferentialLintField
|
|
extends DifferentialCustomField {
|
|
|
|
public function getFieldKey() {
|
|
return 'differential:lint';
|
|
}
|
|
|
|
public function getFieldName() {
|
|
return pht('Lint');
|
|
}
|
|
|
|
public function getFieldDescription() {
|
|
return pht('Shows lint results.');
|
|
}
|
|
|
|
public function shouldAppearInPropertyView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderPropertyViewLabel() {
|
|
return $this->getFieldName();
|
|
}
|
|
|
|
public function getRequiredDiffPropertiesForRevisionView() {
|
|
return array(
|
|
'arc:lint',
|
|
'arc:lint-excuse',
|
|
'arc:lint-postponed',
|
|
);
|
|
}
|
|
|
|
public function renderPropertyViewValue(array $handles) {
|
|
$diff = $this->getObject()->getActiveDiff();
|
|
|
|
$path_changesets = mpull($diff->loadChangesets(), 'getID', 'getFilename');
|
|
|
|
$lstar = DifferentialRevisionUpdateHistoryView::renderDiffLintStar($diff);
|
|
$lmsg = DifferentialRevisionUpdateHistoryView::getDiffLintMessage($diff);
|
|
$ldata = $diff->getProperty('arc:lint');
|
|
$ltail = null;
|
|
|
|
$rows = array();
|
|
|
|
$rows[] = array(
|
|
'style' => 'star',
|
|
'name' => $lstar,
|
|
'value' => $lmsg,
|
|
'show' => true,
|
|
);
|
|
|
|
$excuse = $diff->getProperty('arc:lint-excuse');
|
|
if ($excuse) {
|
|
$rows[] = array(
|
|
'style' => 'excuse',
|
|
'name' => 'Excuse',
|
|
'value' => phutil_escape_html_newlines($excuse),
|
|
'show' => true,
|
|
);
|
|
}
|
|
|
|
$show_limit = 10;
|
|
$hidden = array();
|
|
|
|
if ($ldata) {
|
|
$ldata = igroup($ldata, 'path');
|
|
foreach ($ldata as $path => $messages) {
|
|
|
|
$rows[] = array(
|
|
'style' => 'section',
|
|
'name' => $path,
|
|
'show' => $show_limit,
|
|
);
|
|
|
|
foreach ($messages as $message) {
|
|
$path = idx($message, 'path');
|
|
$line = idx($message, 'line');
|
|
|
|
$code = idx($message, 'code');
|
|
$severity = idx($message, 'severity');
|
|
|
|
$name = idx($message, 'name');
|
|
$description = idx($message, 'description');
|
|
|
|
$line_link = 'line '.intval($line);
|
|
if (isset($path_changesets[$path])) {
|
|
$href = '#C'.$path_changesets[$path].'NL'.max(1, $line);
|
|
|
|
// TODO: We are always showing the active diff
|
|
// if ($diff->getID() != $this->getDiff()->getID()) {
|
|
// $href = '/D'.$diff->getRevisionID().'?id='.$diff->getID().$href;
|
|
// }
|
|
|
|
$line_link = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
),
|
|
$line_link);
|
|
}
|
|
|
|
if ($show_limit) {
|
|
--$show_limit;
|
|
$show = true;
|
|
} else {
|
|
$show = false;
|
|
if (empty($hidden[$severity])) {
|
|
$hidden[$severity] = 0;
|
|
}
|
|
$hidden[$severity]++;
|
|
}
|
|
|
|
$rows[] = array(
|
|
'style' => $this->getSeverityStyle($severity),
|
|
'name' => ucwords($severity),
|
|
'value' => hsprintf(
|
|
'(%s) %s at %s',
|
|
$code,
|
|
$name,
|
|
$line_link),
|
|
'show' => $show,
|
|
);
|
|
|
|
if (!empty($message['locations'])) {
|
|
$locations = array();
|
|
foreach ($message['locations'] as $location) {
|
|
$other_line = idx($location, 'line');
|
|
$locations[] =
|
|
idx($location, 'path', $path).
|
|
($other_line ? ":{$other_line}" : "");
|
|
}
|
|
$description .= "\nOther locations: ".implode(", ", $locations);
|
|
}
|
|
|
|
if (strlen($description)) {
|
|
$rows[] = array(
|
|
'style' => 'details',
|
|
'value' => phutil_escape_html_newlines($description),
|
|
'show' => false,
|
|
);
|
|
if (empty($hidden['details'])) {
|
|
$hidden['details'] = 0;
|
|
}
|
|
$hidden['details']++;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
$postponed = $diff->getProperty('arc:lint-postponed');
|
|
if ($postponed) {
|
|
foreach ($postponed as $linter) {
|
|
$rows[] = array(
|
|
'style' => $this->getPostponedStyle(),
|
|
'name' => 'Postponed',
|
|
'value' => $linter,
|
|
'show' => false,
|
|
);
|
|
if (empty($hidden['postponed'])) {
|
|
$hidden['postponed'] = 0;
|
|
}
|
|
$hidden['postponed']++;
|
|
}
|
|
}
|
|
|
|
$show_string = $this->renderShowString($hidden);
|
|
|
|
$view = new DifferentialResultsTableView();
|
|
$view->setRows($rows);
|
|
$view->setShowMoreString($show_string);
|
|
|
|
return $view->render();
|
|
}
|
|
|
|
private function getSeverityStyle($severity) {
|
|
$map = array(
|
|
ArcanistLintSeverity::SEVERITY_ERROR => 'red',
|
|
ArcanistLintSeverity::SEVERITY_WARNING => 'yellow',
|
|
ArcanistLintSeverity::SEVERITY_AUTOFIX => 'yellow',
|
|
ArcanistLintSeverity::SEVERITY_ADVICE => 'yellow',
|
|
);
|
|
return idx($map, $severity);
|
|
}
|
|
|
|
private function getPostponedStyle() {
|
|
return 'blue';
|
|
}
|
|
|
|
private function renderShowString(array $hidden) {
|
|
if (!$hidden) {
|
|
return null;
|
|
}
|
|
|
|
// Reorder hidden things by severity.
|
|
$hidden = array_select_keys(
|
|
$hidden,
|
|
array(
|
|
ArcanistLintSeverity::SEVERITY_ERROR,
|
|
ArcanistLintSeverity::SEVERITY_WARNING,
|
|
ArcanistLintSeverity::SEVERITY_AUTOFIX,
|
|
ArcanistLintSeverity::SEVERITY_ADVICE,
|
|
'details',
|
|
'postponed',
|
|
)) + $hidden;
|
|
|
|
$show = array();
|
|
foreach ($hidden as $key => $value) {
|
|
switch ($key) {
|
|
case ArcanistLintSeverity::SEVERITY_ERROR:
|
|
$show[] = pht('%d Error(s)', $value);
|
|
break;
|
|
case ArcanistLintSeverity::SEVERITY_WARNING:
|
|
$show[] = pht('%d Warning(s)', $value);
|
|
break;
|
|
case ArcanistLintSeverity::SEVERITY_AUTOFIX:
|
|
$show[] = pht('%d Auto-Fix(es)', $value);
|
|
break;
|
|
case ArcanistLintSeverity::SEVERITY_ADVICE:
|
|
$show[] = pht('%d Advice(s)', $value);
|
|
break;
|
|
case 'details':
|
|
$show[] = pht('%d Detail(s)', $value);
|
|
break;
|
|
case 'postponed':
|
|
$show[] = pht('%d Postponed', $value);
|
|
break;
|
|
default:
|
|
$show[] = $value;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return "Show Full Lint Results (".implode(', ', $show).")";
|
|
}
|
|
|
|
public function getWarningsForDetailView() {
|
|
$status = $this->getObject()->getActiveDiff()->getLintStatus();
|
|
if ($status < DifferentialLintStatus::LINT_WARN) {
|
|
return array();
|
|
}
|
|
|
|
$warnings = array();
|
|
if ($status == DifferentialLintStatus::LINT_SKIP) {
|
|
$warnings[] = pht(
|
|
'Lint was skipped when generating these changes.');
|
|
} else if ($status == DifferentialLintStatus::LINT_POSTPONED) {
|
|
$warnings[] = pht(
|
|
'Background linting has not finished executing on these changes.');
|
|
} else {
|
|
$warnings[] = pht('These changes have lint problems.');
|
|
}
|
|
|
|
return $warnings;
|
|
}
|
|
|
|
}
|