1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/doorkeeper
epriestley fca534d6b6 Improve Asana API error handling in Doorkeeper
Summary:
Ref T2852. We need to distinguish between an API call which worked but got back nothing (404) and an API call which failed.

In particular, Asana hit a sync issue which was likely the result of treating a 500 (or some other error) as a 404.

Also clean up a couple small things.

Test Plan: Ran syncs against deleted tasks and saw successful syncs of non-tasks, and simulated random failures and saw them get handled correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6470
2013-07-16 10:29:52 -07:00
..
application Minor, override the correct method. 2013-06-28 11:57:17 -07:00
bridge Improve Asana API error handling in Doorkeeper 2013-07-16 10:29:52 -07:00
controller Add remarkup support for Asana URIs 2013-06-24 15:55:08 -07:00
engine Improve Asana API error handling in Doorkeeper 2013-07-16 10:29:52 -07:00
option Make it easier to configure an Asana workspace ID 2013-07-12 13:10:03 -07:00
query Add DoorkeeperExternalObjectQuery, expose more ref/import APIs 2013-06-25 16:30:44 -07:00
remarkup Use remarkup rule priorities in Phabricator 2013-07-01 12:29:15 -07:00
storage Add DoorkeeperExternalObjectQuery, expose more ref/import APIs 2013-06-25 16:30:44 -07:00
worker Improve Asana API error handling in Doorkeeper 2013-07-16 10:29:52 -07:00