1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/repository
Juan Pablo Civile 8e0a975e3f Remove calls to DifferentialRevision::loadRelations from commit workers
Summary:
Remove ocurrences of `loadRelations` in workers.

One was simply unnecesary, no subsequent call to `getReviewers` or `getCCPHIDs` was made.
The other was replaced with the nicer `DifferentialRevisionQuery` using `needRelations` and `needReviewerStatus` (for future upgrade).

Test Plan:
Land a revision into a tracked repository and check the parser worker attached the commit correctly.
For the owners worker I just checked it didn't crash into a hundred tiny pieces.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6467
2013-07-15 18:39:55 -07:00
..
application Use application icons for "Eye" menu and Crumbs 2012-12-07 13:37:28 -08:00
conduit Minor, correct more application class name spellings. 2013-05-15 17:01:34 -07:00
constants Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
controller Update form styles, implement in many places 2013-05-07 14:07:06 -07:00
daemon Phabricator event timeline removed 2013-07-09 18:07:42 -07:00
editor Provide transaction-based edits of repository encoding 2013-05-25 06:30:38 -07:00
engine Minor, fix a variable name that I derped in recent refactoring. 2013-05-20 12:41:09 -07:00
management Make repository discovery partially testable 2013-05-12 19:08:37 -07:00
query Begin transacitonalizing repository edits and provide a more sensible edit interface 2013-05-24 12:37:42 -07:00
search Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
storage Use %P for all sensitive command construction in Phabricator 2013-07-03 15:13:45 -07:00
worker Remove calls to DifferentialRevision::loadRelations from commit workers 2013-07-15 18:39:55 -07:00
PhabricatorRepositoryConfigOptions.php Repository option. 2013-01-16 09:35:48 -08:00