epriestley 2b9838b482 Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus ... Summary: Ref T2543. This cleans up a couple of remaining rough edges: - We could do an older TYPE_ACTION "close" via the daemons. - We could do an older TYPE_ACTION "close" via `arc close-revision`, explicitly or implicitly in `arc land`, via API (`differential.close`). - We could do an older TYPE_ACTION "rethink" ("Plan Changes") via the API, via `arc diff --plan-changes` (`differential.createcomment`). Move these to modern modular transactions, then get rid of all the validation and application logic for them. This nukes a bunch of `ArcanistDifferentialRevision::...` junk. Test Plan: - Used `bin/repository reparse --message rXYZ...` to reparse a commit, closing a corresponding revision. - Used `differential.close` to close a revision. - Used `differential.createcomment` to plan changes to a revision. - Reviewed transaction log for full "closed by commit" message (linking to commit and mentioning author). - Grepped for `::TYPE_ACTION` to look for remaining callsites, didn't find any. - Grepped for `differential.close` and `differential.createcomment` in `arcanist/` to look for anything suspicious, seemed clean. Reviewers: chad Reviewed By: chad Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18412		2017-08-11 17:20:55 -07:00
..
DifferentialCloseConduitAPIMethod.php	Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus	2017-08-11 17:20:55 -07:00
DifferentialConduitAPIMethod.php	Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine	2016-12-16 10:08:49 -08:00
DifferentialCreateCommentConduitAPIMethod.php	Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus	2017-08-11 17:20:55 -07:00
DifferentialCreateDiffConduitAPIMethod.php	Modularize content sources	2016-03-26 11:59:45 -07:00
DifferentialCreateInlineConduitAPIMethod.php	phtize all the things	2015-05-22 21:16:39 +10:00
DifferentialCreateRawDiffConduitAPIMethod.php	Modularize content sources	2016-03-26 11:59:45 -07:00
DifferentialCreateRevisionConduitAPIMethod.php	Rename "getReviewerStatus()" to "getReviewers()"	2017-03-20 17:11:40 -07:00
DifferentialGetAllDiffsConduitAPIMethod.php	phtize all the things	2015-05-22 21:16:39 +10:00
DifferentialGetCommitMessageConduitAPIMethod.php	Rename "needReviewerStatus()" into "needReviewers()"	2017-03-20 16:46:16 -07:00
DifferentialGetCommitPathsConduitAPIMethod.php	phtize all the things	2015-05-22 21:16:39 +10:00
DifferentialGetDiffConduitAPIMethod.php	phtize all the things	2015-05-22 21:16:39 +10:00
DifferentialGetRawDiffConduitAPIMethod.php	Give Conduit params/return/errors protected visibility	2015-04-13 11:58:35 -07:00
DifferentialGetRevisionCommentsConduitAPIMethod.php	phtize all the things	2015-05-22 21:16:39 +10:00
DifferentialGetRevisionConduitAPIMethod.php	Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator	2017-08-09 11:04:52 -07:00
DifferentialParseCommitMessageConduitAPIMethod.php	Remove "Revision ID" custom field	2016-12-16 10:22:28 -08:00
DifferentialQueryConduitAPIMethod.php	Remove legacy withStatus() method from RevisionQuery	2017-08-11 13:37:47 -07:00
DifferentialQueryDiffsConduitAPIMethod.php	Make differential.querydiffs more liberal about arguments	2017-01-10 13:47:38 -08:00
DifferentialRevisionEditConduitAPIMethod.php	Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine	2016-12-16 10:08:49 -08:00
DifferentialRevisionSearchConduitAPIMethod.php	Implement basic differential.revision.search	2016-06-09 09:06:58 -07:00
DifferentialSetDiffPropertyConduitAPIMethod.php	Remove some obsolete lint and unit support	2015-08-10 14:16:25 -07:00
DifferentialUpdateRevisionConduitAPIMethod.php	Reduce STATUS_CLOSED (now internally "Published") revision status callsites	2017-08-09 11:05:42 -07:00