1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
phorge-phorge/src/infrastructure/daemon
epriestley 4b10bc2b64 Correct schema irregularities (including weird keys) with worker task tables
Summary:
Ref T13253. Fixes T6615. See that task for discussion.

  - Remove three keys which serve no real purpose: `dataID` doesn't do anything for us, and the two `leaseOwner` keys are unused.
  - Rename `leaseOwner_2` to `key_owner`.
  - Fix an issue where `dataID` was nullable in the active table and non-nullable in the archive table.

In practice, //all// workers have data, so all workers have a `dataID`: if they didn't, we'd already fatal when trying to move tasks to the archive table. Just clean this up for consistency, and remove the ancient codepath which imagined tasks with no data.

Test Plan:
  - Ran `bin/storage upgrade`, inspected tables.
  - Ran `bin/phd debug taskmaster`, worked through a bunch of tasks with no problems.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13253, T6615

Differential Revision: https://secure.phabricator.com/D20175
2019-02-15 19:17:33 -08:00
..
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
control Extend from Phobject 2015-06-15 18:02:27 +10:00
garbagecollector Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
overseer Improve daemon "waiting" message, config reload behavior 2017-03-24 08:32:08 -07:00
workers Correct schema irregularities (including weird keys) with worker task tables 2019-02-15 19:17:33 -08:00
PhabricatorDaemon.php When already running as the daemon user, don't "sudo" daemon commands 2016-08-11 16:41:19 -07:00