1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential/render
epriestley 4566b86376 Fix two diff rendering bugs
Summary:
  - The order of operations for file changes is wrong. We need to wrap them in a table, then render the changeset talbe around that table.
  - Line data was being set to late, so renderShield() got the wrong line count and rendered empty diffs behind, e.g., generated changes.

Test Plan: Looked at an image change with property changes. Clicked "show file contents" on a generated file.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4432
2013-01-15 08:07:40 -08:00
..
DifferentialChangesetHTMLRenderer.php Render inline comments somewhat-correctly on 1-up diffs 2013-01-14 14:20:54 -08:00
DifferentialChangesetOneUpRenderer.php Render inline comments somewhat-correctly on 1-up diffs 2013-01-14 14:20:54 -08:00
DifferentialChangesetOneUpTestRenderer.php Implement basic one-up and test renderers 2013-01-14 14:20:06 -08:00
DifferentialChangesetRenderer.php Render inline comments somewhat-correctly on 1-up diffs 2013-01-14 14:20:54 -08:00
DifferentialChangesetTestRenderer.php Render inline comments somewhat-correctly on 1-up diffs 2013-01-14 14:20:54 -08:00
DifferentialChangesetTwoUpRenderer.php Fix two diff rendering bugs 2013-01-15 08:07:40 -08:00
DifferentialChangesetTwoUpTestRenderer.php Implement basic one-up and test renderers 2013-01-14 14:20:06 -08:00