mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
0c48c1f487
Summary: See discussion in T404. Basically, the problem with date-only controls is that they may behave unpredictably in the presence of timezones. When you say "This needs to be done by Oct 23", you probably mean "Oct 23 5PM PST" or something like that, but someone in China may see the "Oct 24" and hit the deadline in good faith but be 10 hours too late. T404 has more discussion and examples. There are ways to fake this, but they get more complicated if the guy in China needs to move the date forward 24 hours. I think the best solution to this is to not have date-only controls, and always display the time. This makes it absolutley unambiguous what something means, because the guy in the US will set "Oct 23 5PM" and the guy in China will see that accurately in local time. The downside is that it's slightly more visual clutter and work for the user to specify things precisely, but I added some hints (start/end of day, start/end of business) that will hopefully let us pick the right default in most cases. Test Plan: Set some dates. {F21956} This has a couple of edge case issues on resize and some not-so-edge-case issues on mobile, but should be good to build T407 on without API changes. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T404, T407 Differential Revision: https://secure.phabricator.com/D3793 |
||
|---|---|---|
| .. | ||
| control | ||
| AphrontErrorView.php | ||
| AphrontFormInsetView.php | ||
| AphrontFormLayoutView.php | ||
| AphrontFormView.php | ||