1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/infrastructure/markup
epriestley fda0b086b5 Make #🐳 work properly
Summary:
Ref T6223. Two issues:

  - We don't use `/u` mode on these regexps. Without `/u`, the `\w`/`\W`/`\s`/`\S` modifiers have bad behavior on non-ASCII bytes. Add the flag to use unicode mode, making `\w` and `\s` behave like we expect.
    - We might possibly want to do something different here eventually (for example, if the `/u` flag has some huge performance penalty) but this seems OK for now.
  - We use `\b` (word boundary) to terminate the match, but `🐳` is not a word character. Use `(?!\w)` instead ("don't match before a word character") which is what we mean.

Test Plan: {F211498}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T6223

Differential Revision: https://secure.phabricator.com/D10618
2014-10-01 12:45:31 -07:00
..
interpreter Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
rule Make #🐳 work properly 2014-10-01 12:45:31 -07:00
PhabricatorMarkupEngine.php Add a remarkup element for a navigation sequence 2014-08-26 12:14:28 -07:00
PhabricatorMarkupInterface.php Remove @group annotations 2014-07-10 08:12:48 +10:00
PhabricatorMarkupOneOff.php Make sure READMEs can hit the markup cache in Diffusion 2014-05-12 11:47:31 -07:00
PhabricatorMarkupPreviewController.php Add a "document" style to PHUIRemarkupPreviewPanel and use it in Legalpad and Phriction 2013-08-05 10:47:26 -07:00
PhabricatorSyntaxHighlighter.php Remove @group annotations 2014-07-10 08:12:48 +10:00