mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 18:32:41 +01:00
0be3db03ee
Summary:
I think this is the last major step -- use the fields to parse commit messages,
not a hard-coded list of stuff. This adds two primary methods to fields, one to
get all the labels they'll parse (so we can do "CC" and "CCs" and treat them as
the same field) and one to parse the string into a canonical representation
(e.g., lookup reviewers and such).
You'll need to impelement the one block of task-specific stuff I removed in
Facebook's task field:
list($pre_comment) = split(' -- ', $data);
$data = array_filter(preg_split('/[^\d]+/', $pre_comment));
foreach ($data as $k => $v) {
$data[$k] = (int)$v;
}
$data = array_unique($data);
break;
Otherwise I think this is clean.
Test Plan:
- Called the conduit method with various commit messages, parsed fields/errors
seemed correct.
- "arc diff"'d this diff onto localhost, then updated it.
- "arc amend"'d this diff.
Reviewers: jungejason, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason, epriestley
Differential Revision: 829
118 lines
2.6 KiB
PHP
118 lines
2.6 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2011 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialRevertPlanFieldSpecification
|
|
extends DifferentialFieldSpecification {
|
|
|
|
private $value;
|
|
|
|
public function getStorageKey() {
|
|
return 'phabricator:revert-plan';
|
|
}
|
|
|
|
public function getValueForStorage() {
|
|
return $this->value;
|
|
}
|
|
|
|
public function setValueFromStorage($value) {
|
|
$this->value = $value;
|
|
return $this;
|
|
}
|
|
|
|
public function shouldAppearOnEdit() {
|
|
return true;
|
|
}
|
|
|
|
public function setValueFromRequest(AphrontRequest $request) {
|
|
$this->value = $request->getStr($this->getStorageKey());
|
|
return $this;
|
|
}
|
|
|
|
public function renderEditControl() {
|
|
return id(new AphrontFormTextAreaControl())
|
|
->setLabel('Revert Plan')
|
|
->setName($this->getStorageKey())
|
|
->setCaption('Special steps required to safely revert this change.')
|
|
->setValue($this->value);
|
|
}
|
|
|
|
public function validateField() {
|
|
return;
|
|
}
|
|
|
|
public function shouldAppearOnRevisionView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForRevisionView() {
|
|
return 'Revert Plan:';
|
|
}
|
|
|
|
public function renderValueForRevisionView() {
|
|
if (!$this->value) {
|
|
return null;
|
|
}
|
|
return phutil_escape_html($this->value);
|
|
}
|
|
|
|
public function shouldAppearOnConduitView() {
|
|
return true;
|
|
}
|
|
|
|
public function getValueForConduit() {
|
|
return $this->value;
|
|
}
|
|
|
|
public function shouldAppearOnCommitMessage() {
|
|
return true;
|
|
}
|
|
|
|
public function getCommitMessageKey() {
|
|
return 'revertPlan';
|
|
}
|
|
|
|
public function setValueFromParsedCommitMessage($value) {
|
|
$this->value = $value;
|
|
return $this;
|
|
}
|
|
|
|
public function shouldOverwriteWhenCommitMessageIsEdited() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForCommitMessage() {
|
|
return 'Revert Plan';
|
|
}
|
|
|
|
|
|
public function renderValueForCommitMessage($is_edit) {
|
|
return $this->value;
|
|
}
|
|
|
|
public function getSupportedCommitMessageLabels() {
|
|
return array(
|
|
'Revert Plan',
|
|
'Revert',
|
|
);
|
|
}
|
|
|
|
public function parseValueFromCommitMessage($value) {
|
|
return $value;
|
|
}
|
|
|
|
}
|