mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 09:42:41 +01:00
0902543fc8
Summary: - Ports MySQL settings to PHP. - Removes "mysql.retries" -- this existed only because Magic Numbers Are Bad, but there is no concievable reason it should ever be set to anything other than 3. - Introduced "Hidden" config, which isn't visible from the web (for SaaS, we'll just mark anything with secret keys as "hidden"). - Introduced "Masked" config, which will be masked in darkconsole once that gets updated. - "Hidden" implies "Masked" and "Locked". - Moved "storage.default-namespace" here -- it probably makes more sense than core; this was my bad in T2255. - Put cancel button back for hidden/locked config. - Introduce 'class' config type. Test Plan: Viewed MySQL options. None are editable. Reviewers: codeblock, btrahan Reviewed By: codeblock CC: aran Maniphest Tasks: T2255 Differential Revision: https://secure.phabricator.com/D4326
161 lines
4.6 KiB
PHP
161 lines
4.6 KiB
PHP
<?php
|
|
|
|
abstract class PhabricatorApplicationConfigOptions extends Phobject {
|
|
|
|
abstract public function getName();
|
|
abstract public function getDescription();
|
|
abstract public function getOptions();
|
|
|
|
public function validateOption(PhabricatorConfigOption $option, $value) {
|
|
if ($value === $option->getDefault()) {
|
|
return;
|
|
}
|
|
|
|
if ($value === null) {
|
|
return;
|
|
}
|
|
|
|
switch ($option->getType()) {
|
|
case 'bool':
|
|
if ($value !== true &&
|
|
$value !== false) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' is of type bool, but value is not true or false.",
|
|
$option->getKey()));
|
|
}
|
|
break;
|
|
case 'int':
|
|
if (!is_int($value)) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' is of type int, but value is not an integer.",
|
|
$option->getKey()));
|
|
}
|
|
break;
|
|
case 'string':
|
|
if (!is_string($value)) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' is of type string, but value is not a string.",
|
|
$option->getKey()));
|
|
}
|
|
break;
|
|
case 'class':
|
|
$symbols = id(new PhutilSymbolLoader())
|
|
->setType('class')
|
|
->setAncestorClass($option->getBaseClass())
|
|
->setConcreteOnly(true)
|
|
->selectSymbolsWithoutLoading();
|
|
$names = ipull($symbols, 'name', 'name');
|
|
if (empty($names[$value])) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' value must name a class extending '%s'.",
|
|
$option->getKey(),
|
|
$option->getBaseClass()));
|
|
}
|
|
break;
|
|
case 'list<string>':
|
|
$valid = true;
|
|
if (!is_array($value)) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' must be a list of strings, but value is not ".
|
|
"an array.",
|
|
$option->getKey()));
|
|
}
|
|
if ($value && array_keys($value) != range(0, count($value) - 1)) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' must be a list of strings, but the value is a ".
|
|
"map with unnatural keys.",
|
|
$option->getKey()));
|
|
}
|
|
foreach ($value as $v) {
|
|
if (!is_string($v)) {
|
|
throw new PhabricatorConfigValidationException(
|
|
pht(
|
|
"Option '%s' must be a list of strings, but it contains one ".
|
|
"or more non-strings.",
|
|
$option->getKey()));
|
|
}
|
|
}
|
|
break;
|
|
case 'wild':
|
|
default:
|
|
break;
|
|
}
|
|
|
|
$this->didValidateOption($option, $value);
|
|
}
|
|
|
|
protected function didValidateOption(
|
|
PhabricatorConfigOption $option,
|
|
$value) {
|
|
// Hook for subclasses to do complex validation.
|
|
return;
|
|
}
|
|
|
|
public function getKey() {
|
|
$class = get_class($this);
|
|
$matches = null;
|
|
if (preg_match('/^Phabricator(.*)ConfigOptions$/', $class, $matches)) {
|
|
return strtolower($matches[1]);
|
|
}
|
|
return strtolower(get_class($this));
|
|
}
|
|
|
|
final protected function newOption($key, $type, $default) {
|
|
return id(new PhabricatorConfigOption())
|
|
->setKey($key)
|
|
->setType($type)
|
|
->setDefault($default)
|
|
->setGroup($this);
|
|
}
|
|
|
|
final public static function loadAll() {
|
|
$symbols = id(new PhutilSymbolLoader())
|
|
->setAncestorClass('PhabricatorApplicationConfigOptions')
|
|
->setConcreteOnly(true)
|
|
->selectAndLoadSymbols();
|
|
|
|
$groups = array();
|
|
foreach ($symbols as $symbol) {
|
|
$obj = newv($symbol['name'], array());
|
|
$key = $obj->getKey();
|
|
if (isset($groups[$key])) {
|
|
$pclass = get_class($groups[$key]);
|
|
$nclass = $symbol['name'];
|
|
|
|
throw new Exception(
|
|
"Multiple PhabricatorApplicationConfigOptions subclasses have the ".
|
|
"same key ('{$key}'): {$pclass}, {$nclass}.");
|
|
}
|
|
$groups[$key] = $obj;
|
|
}
|
|
|
|
return $groups;
|
|
}
|
|
|
|
final public static function loadAllOptions() {
|
|
$groups = self::loadAll();
|
|
|
|
$options = array();
|
|
foreach ($groups as $group) {
|
|
foreach ($group->getOptions() as $option) {
|
|
$key = $option->getKey();
|
|
if (isset($options[$key])) {
|
|
throw new Exception(
|
|
"Mulitple PhabricatorApplicationConfigOptions subclasses contain ".
|
|
"an option named '{$key}'!");
|
|
}
|
|
$options[$key] = $option;
|
|
}
|
|
}
|
|
|
|
return $options;
|
|
}
|
|
|
|
|
|
}
|