1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/repository
epriestley 553c335fbd Ignore unreachable commits when testing if a repository has imported
Summary:
Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via `bin/repository importing`.

Test Plan:
  - Stopped daemons.
  - Created a new repository and activated it.
  - Ran `bin/repository update Rxx`.
  - Deleted a branch in the repository.
  - Ran `bin/repository update Rxx`.
  - Ran daemons to flush queue.

Now:

  - Ran `bin/repository importing`. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  - Ran `bin/repository update`. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11309

Differential Revision: https://secure.phabricator.com/D16269
2016-07-11 09:23:08 -07:00
..
conduit Remove "repository.create" Conduit API method 2016-05-04 16:10:19 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
constants Give users a modal VCS choice when creating a new repository 2016-04-29 09:20:31 -07:00
customfield Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
daemon Handle tag tags properly in discovery 2016-06-20 11:10:02 -07:00
data Remove all uses of PhutilGitURI in Phabricator 2016-06-13 07:20:58 -07:00
editor Provide more UI guidance when creating repositories 2016-05-11 06:35:35 -07:00
engine Only load refs that are actual commits 2016-07-08 22:34:25 +00:00
graphcache Remove duplicated duplicated words 2015-06-27 08:43:44 -07:00
mail Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
management Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
phid Mark unreachable commits handles as "closed" 2016-06-16 13:01:09 -07:00
query Index all repository URIs, not just the "primary" repository URI 2016-05-11 06:36:06 -07:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Inch toward using ApplicationSearch to power related objects 2016-06-29 11:22:29 -07:00
storage Expose repository "importing" flag via diffusion.repository.search 2016-07-06 19:18:39 -07:00
worker Make permanent worker failures more user-friendly 2016-07-11 09:21:39 -07:00