1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-03 02:18:24 +01:00
phorge-phorge/src/applications/config
Andre Klapper 0ceb44c38a Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15324

Test Plan: Applied this change and `/config/settings/` rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15324

Differential Revision: https://we.phorge.it/D25171
2023-05-03 10:24:52 +02:00
..
application Remove product literal strings in "pht()", part 2 2022-04-25 12:22:26 -07:00
check Fix numerous PHP 8.1 "strlen(null)" exceptions preventing homepage to display 2023-04-27 14:08:48 +02:00
constants Config re-design 2017-09-05 15:24:15 -07:00
controller Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page 2023-05-03 10:24:52 +02:00
custom Remove product literal strings in "pht()", part 3 2022-04-25 12:22:26 -07:00
editor Remove product literal strings in "pht()", part 3 2022-04-25 12:22:26 -07:00
engine When we "discover" new fatal setup issues, stop serving traffic 2016-11-21 15:54:40 -08:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
issue Remove product literal strings in "pht()", part 16 2022-04-25 16:46:25 -07:00
json Improve UI formatting of some configuration values 2015-12-05 09:58:47 -08:00
management Allow bin/config to create config file 2019-09-08 00:16:19 +00:00
module Split setup checks into "preflight" and "normal" checks 2016-09-06 11:57:18 -07:00
option Remove product literal strings in "pht()", part 16 2022-04-25 16:46:25 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
response Remove product literal strings in "pht()", part 4 2022-04-25 12:22:27 -07:00
schema Update MySQL schema inspection code for deprecation of integer display widths 2020-05-18 12:10:31 -07:00
storage Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
type Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" 2019-02-28 07:29:36 -08:00
view Remove product literal strings in "pht()", part 4 2022-04-25 12:22:27 -07:00