1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/herald
epriestley b592630d72 Provide more structure to PHUIObjectBoxView
Summary:
Three changes here.

  - Add `setActionList()`, and use that to set the action list.
  - Add `setPropertyList()`, and use that to set the property list.

These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors.

  - Replace `addContent()` with `appendChild()`.

This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing.

Test Plan:
  - Viewed "All Config".
  - Viewed a countdown.
  - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history).
  - Viewed Diffusion (browse, change, history, repository, lint).
  - Viewed Drydock (resource, lease).
  - Viewed Files.
  - Viewed Herald.
  - Viewed Legalpad.
  - Viewed macro (edit, edit audio, view).
  - Viewed Maniphest.
  - Viewed Applications.
  - Viewed Paste.
  - Viewed People.
  - Viewed Phulux.
  - Viewed Pholio.
  - Viewed Phame (blog, post).
  - Viewed Phortune (account, product).
  - Viewed Ponder (questions, answers, comments).
  - Viewed Releeph.
  - Viewed Projects.
  - Viewed Slowvote.

NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose?

NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7174
2013-09-30 09:36:04 -07:00
..
adapter Herald - tighten up rule display 2013-09-27 12:05:58 -07:00
application Add a normal "view" page for Herald rules 2013-08-07 18:04:39 -07:00
config Remove HeraldActionConfig, HeraldFieldConfig 2013-08-07 18:04:37 -07:00
controller Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
engine Herald - make dry runs work for "apply once" rules after they have been applied 2013-09-13 11:38:49 -07:00
phid Policy - introduce parentQuery and pass around policy configuration from parent to child 2013-09-11 12:19:34 -07:00
query Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
storage Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
view Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00