1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-27 05:59:08 +01:00
phorge-phorge/src/applications/maniphest
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
application Prepare for hovercards 2013-02-26 14:59:31 -08:00
auxiliaryfield Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
conduit Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
config Maniphest / MetaMTA config options 2013-01-16 09:01:32 -08:00
constants getConfigEnv fails fast when key is not found and no default value is given. 2013-01-19 12:11:28 -08:00
controller Require a viewer to load handles 2013-02-28 17:15:09 -08:00
editor Require a viewer to load handles 2013-02-28 17:15:09 -08:00
event Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
extensions Delete license headers from files 2012-11-05 11:16:51 -08:00
remarkup Missing change from D5120 which I incorrectly discarded in a merge. 2013-02-27 07:19:57 -08:00
search Require a viewer to load handles 2013-02-28 17:15:09 -08:00
storage Fix a MySQL strict issue with auxiliary task storage 2013-02-27 10:51:34 -08:00
view changed wordwrap call to utf8 hard wrap call in multiple places 2013-02-28 09:17:58 -08:00
ManiphestReplyHandler.php Delete license headers from files 2012-11-05 11:16:51 -08:00
ManiphestTaskQuery.php Require a viewer to load handles 2013-02-28 17:15:09 -08:00