1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
phorge-phorge/src/applications/diffusion/controller
epriestley c04147328f Fix isValidGitShallowCloneResponse
Summary:
Changes the heuristic method by which non-zero exit statuses from git-http-backend are found to be due to packfile negotiation during shallow fetches, etc.

Instead of checking git-http-backend stderr for a generic "hung up" error message, see if the pack-result response contains a terminating flush packet ("0000"). This should give a greater assurance that the request was handled correctly and the response is complete.

Test Plan: Run `GIT_CURL_VERBOSE=1 git fetch --depth 1 https://host.example/source/repo.git HEAD` to ensure it completes and includes two successful POST requests during packfile negotiation (the last one actually receives the packfile).

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, dzduvall

Tags: #diffusion

Differential Revision: https://secure.phabricator.com/D21484
2020-10-30 13:46:24 -07:00
..
DiffusionBlameController.php Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()" 2019-04-24 05:53:35 -07:00
DiffusionBranchTableController.php Make branch status more clear on Diffusion branches view 2019-05-16 12:24:39 -07:00
DiffusionBrowseController.php Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" 2020-08-12 08:59:53 -07:00
DiffusionChangeController.php Remove all whitespace options/configuration everywhere 2019-02-19 13:09:29 -08:00
DiffusionCloneController.php Move Clone Repository to Dialog 2017-07-11 13:16:47 -07:00
DiffusionCommitBranchesController.php If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..." 2018-06-22 17:38:19 -07:00
DiffusionCommitController.php Wrap all direct access to author/committer properties on "CommitData" 2020-09-15 17:36:39 -07:00
DiffusionCommitEditController.php Replace old commit edit controller with new EditEngine controller 2017-01-11 10:37:53 -08:00
DiffusionCommitListController.php Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
DiffusionCommitTagsController.php Show first 10 branches, then "More Branches" for commits on huge numbers of branches 2016-02-16 15:10:01 -08:00
DiffusionCompareController.php Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" 2020-08-12 08:59:53 -07:00
DiffusionController.php Remove the "Graph" view as a dedicated repository view 2020-08-12 08:59:16 -07:00
DiffusionDiffController.php Move the "Inline List" view to "DiffInlineCommentQuery" 2020-05-07 16:07:23 -07:00
DiffusionDocumentController.php Move Diffusion browse rendering to DocumentEngine, breaking almost all features 2018-04-09 04:46:26 -07:00
DiffusionExternalController.php Fix two issues with callsign-free repositories 2016-02-26 06:13:46 -08:00
DiffusionHistoryController.php Move the view of merged changes to "DiffusionCommitGraphView" 2020-08-12 08:59:46 -07:00
DiffusionIdentityEditController.php Add controllers/search/edit engine functionality to RepositoryIdentity 2018-05-31 07:03:25 -07:00
DiffusionIdentityListController.php Add controllers/search/edit engine functionality to RepositoryIdentity 2018-05-31 07:03:25 -07:00
DiffusionIdentityViewController.php Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently 2019-11-19 09:37:44 -08:00
DiffusionInlineCommentController.php Lift inline comment draft behaviors to "InlineController" 2020-05-08 06:52:29 -07:00
DiffusionLastModifiedController.php Remove construction of "author" information from "LastModified" payload in Diffusion 2020-08-12 08:58:32 -07:00
DiffusionLintController.php Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00
DiffusionLogController.php Add a basic view for repository pull logs 2018-01-23 14:10:10 -08:00
DiffusionPathCompleteController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathTreeController.php Modernize most somewhat-weird Diffusion controllers 2016-01-05 14:00:57 -08:00
DiffusionPathValidateController.php Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners 2018-03-07 20:57:24 -08:00
DiffusionPullLogListController.php Make push log "flags", "reject code" human readable; add crumbs to pull/push logs 2018-01-30 15:45:58 -08:00
DiffusionPushEventViewController.php Add a basic view for repository pull logs 2018-01-23 14:10:10 -08:00
DiffusionPushLogListController.php Make push log "flags", "reject code" human readable; add crumbs to pull/push logs 2018-01-30 15:45:58 -08:00
DiffusionRefTableController.php Modernize more Diffusion controllers 2016-01-05 14:00:20 -08:00
DiffusionRepositoryController.php Remove "Recent Commits" from repository landing page 2020-08-12 08:59:07 -07:00
DiffusionRepositoryDefaultController.php Redirect /source/x (no slash) to /source/x/ (canonical) when viewer is logged out and "x" is public 2016-12-20 07:48:20 -08:00
DiffusionRepositoryEditActivateController.php Modularize Repository transactions 2018-11-28 14:29:18 -08:00
DiffusionRepositoryEditController.php Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" 2020-02-04 06:52:23 -08:00
DiffusionRepositoryEditDangerousController.php Modularize Repository transactions 2018-11-28 14:29:18 -08:00
DiffusionRepositoryEditDeleteController.php Modernize user and repository "delete" workflows and improve documentation 2019-08-02 09:30:50 -07:00
DiffusionRepositoryEditEnormousController.php Modularize Repository transactions 2018-11-28 14:29:18 -08:00
DiffusionRepositoryEditPublishingController.php Move the repository "Publishing" option to the "Basics" panel in repository management 2019-04-18 05:24:27 -07:00
DiffusionRepositoryEditUpdateController.php Update Repository Management pages to new fixed UI 2017-09-05 19:01:27 -07:00
DiffusionRepositoryListController.php Make repository identity email address association case-insensitive 2019-11-19 09:37:26 -08:00
DiffusionRepositoryManageController.php Update Repository Management pages to new fixed UI 2017-09-05 19:01:27 -07:00
DiffusionRepositoryManagePanelsController.php Separate the repository management UI into sections 2018-11-28 13:53:30 -08:00
DiffusionRepositoryProfilePictureController.php Add more repo images 2017-08-08 17:51:15 -07:00
DiffusionRepositoryTestAutomationController.php Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
DiffusionRepositoryURICredentialController.php Fill in new URI credential edit web UI interfaces 2016-05-02 04:26:13 -07:00
DiffusionRepositoryURIDisableController.php Prevent users from disabling repository builtin URIs 2016-05-12 12:09:23 -07:00
DiffusionRepositoryURIEditController.php Flesh out more web UI actions for new URI interface 2016-04-29 17:16:15 -07:00
DiffusionRepositoryURIViewController.php Remove completely pointless load of every repository when viewing a repository URI 2018-02-08 12:47:48 -08:00
DiffusionServeController.php Fix isValidGitShallowCloneResponse 2020-10-30 13:46:24 -07:00
DiffusionSymbolController.php Provide character position information to symbol queries 2018-01-26 13:01:57 -08:00
DiffusionSyncLogListController.php Add a basic web UI for intracluster sync logs 2018-11-10 04:58:36 -08:00
DiffusionTagListController.php Add branch, tag info to Diffusion Headers 2017-08-16 12:16:15 -07:00