1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-25 04:59:06 +01:00
phorge-phorge/src/infrastructure/diff
epriestley 6d0dbeb77f Use the changeset parse cache to cache suggestion changesets
Summary:
Ref T13513. Syntax highlighting is potentially expensive, and the changeset rendering pipeline can cache it. However, the cache is currently keyed ONLY by Differential changeset ID.

Destroy the existing cache and rebuild it with a more standard cache key so it can be used in a more ad-hoc way by inline suggestion snippets.

Test Plan: Used Darkconsole, saw cache hits and no more inline syntax highlighting for changesets with many inlines.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21280
2020-05-20 14:29:27 -07:00
..
__tests__ Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on 2019-02-19 10:55:10 -08:00
engine Remove "DifferentialInlineCommentQuery" 2020-05-07 16:07:55 -07:00
inline Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
interface Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
prose In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better 2019-09-25 16:50:49 -07:00
query Put a readthrough cache in front of inline context construction 2020-05-20 14:28:37 -07:00
view Use the changeset parse cache to cache suggestion changesets 2020-05-20 14:29:27 -07:00
viewstate Fix an issue where non-ID changeset state keys were used as changeset IDs 2020-05-04 16:05:05 -07:00
PhabricatorChangesetResponse.php Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion 2020-04-19 08:59:09 -07:00
PhabricatorDifferenceEngine.php Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
PhabricatorDiffScopeEngine.php Make very minor generality improvements to the scope selector 2019-04-30 06:52:29 -07:00
PhabricatorInlineCommentController.php Roughly support inline comment suggestions 2020-05-20 14:26:37 -07:00