1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/harbormaster
epriestley 10b86c2aa3 Don't show meme Remarkup hint button if Macro application is not usable
Summary: See <https://phabricator.wikimedia.org/T906>. This behavior is a bug; we should remove the button if the user can't use the application.

Test Plan:
- With Macro uninstalled, did these things verifying the button vanished:
  - Sent a user a message.
  - Edited a revision.
  - Edited repository basic information.
  - Edited an initiative.
  - Edited a Harbormaster build step.
  - Added task comments.
  - Edited profile blurb.
  - Edited blog description.
  - Commented on Pholio mock.
  - Uploaded Pholio image.
  - Edited Phortune merchant.
  - Edited Phriction document.
  - Edited Ponder answer.
  - Edited Ponder question.
  - Edited Slowvote poll.
  - Edited a comment.
- Reinstalled Macro and saw button come back.
- Used button to put silly text on a funny picture.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10900
2014-11-24 15:25:25 -08:00
..
application Rename "beta" to "prototype" and document support policy 2014-09-17 18:25:57 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
config Migrate "Run Command" to use Drydock hosts 2013-12-05 14:06:22 +11:00
controller Don't show meme Remarkup hint button if Macro application is not usable 2014-11-24 15:25:25 -08:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
editor Minor formatting changes 2014-10-08 08:39:49 +11:00
engine Minor formatting changes 2014-10-08 08:39:49 +11:00
event Implement showing buildable status in Diffusion 2014-06-14 02:28:00 +10:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
interface Move build variables into HarbormasterBuildableInterface 2014-06-20 12:58:23 +10:00
management Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
phid Implement build simulation; convert Harbormaster to be purely dependency based 2014-07-31 11:39:49 +10:00
query Prevent artifact key collision when builds are restarted 2014-08-28 08:21:36 +10:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Minor formatting changes 2014-10-08 08:39:49 +11:00
storage Minor formatting changes 2014-10-08 08:39:49 +11:00
typeahead Implement build simulation; convert Harbormaster to be purely dependency based 2014-07-31 11:39:49 +10:00
view Minor formatting changes 2014-10-08 08:39:49 +11:00
worker Abort previous build targets when a build is restarted 2014-08-26 20:46:23 +10:00