epriestley de1a30efc7 Improve audit behavior for "uninteresting" auditors ... Summary: Ref T10939. Fixes T10174. We can currently trigger "uninteresting" auditors in two ways: - Packages with auditing disabled ("NONE" audits). - Packages with auditing enabled, but they don't need an audit (e.g., author is a pacakge owner; "NOT REQUIRED" audits). These audits aren't interesting (we only write them so we can list "commits in this package" from other UIs) but right now they take up the audit slot. In particular: - They show in the UI, but are generally useless/confusing nowadays. The actual table of contents does a better job of just showing "which packages do these paths belong to" now, and shows all packages for each path. - They block Herald from adding real auditors. Change this: - Don't show uninteresting auditors. - Let Herald upgrade uninteresting auditors into real auditors. Test Plan: - Ran `bin/repository reparse --owners <commit> --force`, and `--herald` to trigger Owners and Herald rules. - With a package with auditing disabled, triggered a "None" audit and saw it no longer appear in the UI with the patch applied. - With a package with auditing disabled, added a Herald rule to trigger an audit. With the patch, saw it go through and upgrade the audit to "Audit Required". Reviewers: chad Reviewed By: chad Maniphest Tasks: T10174, T10939 Differential Revision: https://secure.phabricator.com/D15940		2016-05-17 13:47:33 -07:00
..
DiffusionBranchTableController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionBrowseController.php	Add coverage tooltips in Diffusion file browse mode	2016-04-15 06:59:38 -07:00
DiffusionChangeController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionCommitBranchesController.php	Show first 10 branches, then "More Branches" for commits on huge numbers of branches	2016-02-16 15:10:01 -08:00
DiffusionCommitController.php	Improve audit behavior for "uninteresting" auditors	2016-05-17 13:47:33 -07:00
DiffusionCommitEditController.php	Modernize more Diffusion controllers	2016-01-05 14:00:20 -08:00
DiffusionCommitTagsController.php	Show first 10 branches, then "More Branches" for commits on huge numbers of branches	2016-02-16 15:10:01 -08:00
DiffusionController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionDiffController.php	Modernize most somewhat-weird Diffusion controllers	2016-01-05 14:00:57 -08:00
DiffusionExternalController.php	Fix two issues with callsign-free repositories	2016-02-26 06:13:46 -08:00
DiffusionHistoryController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionInlineCommentController.php	Correctly clear draft markers when deleting an inline comment	2015-07-21 11:36:46 -07:00
DiffusionInlineCommentPreviewController.php	Touch up PHP/JS interactions for inline comments	2015-03-27 17:08:31 -07:00
DiffusionLastModifiedController.php	Make dates/times more concise in Diffusion	2016-03-18 09:11:09 -07:00
DiffusionLintController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionPathCompleteController.php	Modernize most somewhat-weird Diffusion controllers	2016-01-05 14:00:57 -08:00
DiffusionPathTreeController.php	Modernize most somewhat-weird Diffusion controllers	2016-01-05 14:00:57 -08:00
DiffusionPathValidateController.php	Modernize most somewhat-weird Diffusion controllers	2016-01-05 14:00:57 -08:00
DiffusionPushEventViewController.php	Fix an issue with PHID/handle management in push logs	2016-04-20 04:47:10 -07:00
DiffusionPushLogController.php	Diffusion - return 404 errors for bad URIs	2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php	Modernize more Diffusion controllers	2016-01-05 14:00:20 -08:00
DiffusionRefTableController.php	Modernize more Diffusion controllers	2016-01-05 14:00:20 -08:00
DiffusionRepositoryController.php	Clean up display of clone URIs a little bit	2016-05-11 13:14:55 -07:00
DiffusionRepositoryDefaultController.php	Slightly modernize all Diffusion edit endpoints	2016-01-05 14:00:36 -08:00
DiffusionRepositoryEditActivateController.php	Provide more UI guidance when creating repositories	2016-05-11 06:35:35 -07:00
DiffusionRepositoryEditController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryEditDangerousController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryEditDeleteController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryEditUpdateController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryListController.php	Swap Repository Edit UI to new code	2016-05-04 16:19:57 -07:00
DiffusionRepositoryManageController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryManagePanelsController.php	Add a "View Repository" button to the repository manage UI	2016-05-11 09:21:14 -07:00
DiffusionRepositoryTestAutomationController.php	Sort out EditController / ManageController / EditproController Diffusion hierarchy	2016-05-10 05:14:09 -07:00
DiffusionRepositoryURICredentialController.php	Fill in new URI credential edit web UI interfaces	2016-05-02 04:26:13 -07:00
DiffusionRepositoryURIDisableController.php	Prevent users from disabling repository builtin URIs	2016-05-12 12:09:23 -07:00
DiffusionRepositoryURIEditController.php	Flesh out more web UI actions for new URI interface	2016-04-29 17:16:15 -07:00
DiffusionRepositoryURIViewController.php	Prevent users from disabling repository builtin URIs	2016-05-12 12:09:23 -07:00
DiffusionServeController.php	Fix protocol serve detection for clustered repositories that terminate HTTPS	2016-05-05 16:25:14 -07:00
DiffusionSymbolController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00
DiffusionTagListController.php	Update Diffusion UI	2016-03-17 12:05:14 -07:00