1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
phorge-phorge/src/applications/transactions
epriestley 3d3fff4991 Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues
Summary:
Fixes T10381. When we converted to `PHUIRemarkupView`, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).

Fix this so we don't preserve linebreaks.

This also makes `PHUIRemarkupView` a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of `PhabricatorMarkupInterface` / `PhabricatorMarkupOneOff`, and dropping all the application hard-coding in `PhabricatorMarkupEngine`.

Test Plan:
  - Grepped for all callsites, looking for callsites which accept remarkup written in `<<<HEREDOC` format.
  - Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10381

Differential Revision: https://secure.phabricator.com/D15963
2016-05-22 12:23:05 -07:00
..
application Put inline previews in remarkup textareas 2015-12-22 12:18:28 -08:00
commentaction Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
constants Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction 2016-04-06 09:13:31 -07:00
controller Update EditEngine for two column 2016-03-28 09:18:55 -07:00
edges Remove "Used By" from Passphrase 2016-05-16 16:38:52 -07:00
editengine Fix some pagination/redirect issues for repositories 2016-05-06 12:40:20 -07:00
editfield Fix an issue with TextAreaEditField affecting Paste 2016-05-11 15:35:17 -07:00
editor Make View Revision in Mail a little more resilient 2016-05-20 12:07:17 -07:00
edittype Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
engineextension Smooth out milestone creation workflow 2015-12-29 10:40:28 -08:00
error Route task merges through new editor 2013-09-23 14:32:32 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
feed Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Update EditEngine for two column 2016-03-28 09:18:55 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Various translation improvements 2015-11-03 07:02:46 +11:00
storage Special case the "added projects" transaction in mail when creating objects 2016-05-18 07:09:39 -07:00
view Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
worker Modularize content sources 2016-03-26 11:59:45 -07:00