mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-25 21:19:21 +01:00
Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
154 lines
3.7 KiB
PHP
154 lines
3.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group console
|
|
*/
|
|
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
|
|
|
|
public function getName() {
|
|
$count = count($this->getData());
|
|
if ($count) {
|
|
return pht('Error Log (%d)', $count);
|
|
}
|
|
return pht('Error Log');
|
|
}
|
|
|
|
public function getOrder() {
|
|
return 0;
|
|
}
|
|
|
|
public function getColor() {
|
|
if (count($this->getData())) {
|
|
return '#ff0000';
|
|
}
|
|
return null;
|
|
}
|
|
|
|
public function getDescription() {
|
|
return pht('Shows errors and warnings.');
|
|
}
|
|
|
|
public function generateData() {
|
|
return DarkConsoleErrorLogPluginAPI::getErrors();
|
|
}
|
|
|
|
public function renderPanel() {
|
|
$data = $this->getData();
|
|
|
|
$rows = array();
|
|
$details = '';
|
|
|
|
foreach ($data as $index => $row) {
|
|
$file = $row['file'];
|
|
$line = $row['line'];
|
|
|
|
$tag = phutil_tag(
|
|
'a',
|
|
array(
|
|
'onclick' => jsprintf('show_details(%d)', $index),
|
|
),
|
|
$row['str'].' at ['.basename($file).':'.$line.']');
|
|
$rows[] = array($tag);
|
|
|
|
$details .=
|
|
'<div class="dark-console-panel-error-details" id="row-details-'.
|
|
$index.'">'.
|
|
phutil_escape_html($row['details'])."\n".
|
|
'Stack trace:'."\n";
|
|
|
|
foreach ($row['trace'] as $key => $entry) {
|
|
$line = '';
|
|
if (isset($entry['class'])) {
|
|
$line .= $entry['class'].'::';
|
|
}
|
|
$line .= idx($entry, 'function', '');
|
|
$href = null;
|
|
if (isset($entry['file'])) {
|
|
$line .= ' called at ['.$entry['file'].':'.$entry['line'].']';
|
|
try {
|
|
$user = $this->getRequest()->getUser();
|
|
$href = $user->loadEditorLink($entry['file'], $entry['line'], '');
|
|
} catch (Exception $ex) {
|
|
// The database can be inaccessible.
|
|
}
|
|
}
|
|
|
|
$details .= phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
),
|
|
$line);
|
|
$details .= "\n";
|
|
}
|
|
|
|
$details .= '</div>';
|
|
}
|
|
|
|
$table = new AphrontTableView($rows);
|
|
$table->setClassName('error-log');
|
|
$table->setHeaders(array('Error'));
|
|
$table->setNoDataString('No errors.');
|
|
|
|
return '<div>'.
|
|
'<div>'.$table->render().'</div>'.
|
|
'<pre class="PhabricatorMonospaced">'.
|
|
$details.'</pre>'.
|
|
'</div>';
|
|
}
|
|
}
|
|
|
|
/*
|
|
$data = $this->getData();
|
|
if (!$data) {
|
|
return
|
|
<x:frag>
|
|
<div class="mu">No errors.</div>
|
|
</x:frag>;
|
|
}
|
|
|
|
$markup = <table class="LConsoleErrors" />;
|
|
$alt = false;
|
|
foreach ($data as $error) {
|
|
$row = <tr class={$alt ? 'alt' : null} />;
|
|
|
|
$text = $error['error'];
|
|
$text = preg_replace('/\(in .* on line \d+\)$/', '', trim($text));
|
|
|
|
$trace = $error['trace'];
|
|
$trace = explode("\n", $trace);
|
|
if (!$trace) {
|
|
$trace = array('unknown@0@unknown');
|
|
}
|
|
|
|
foreach ($trace as $idx => $traceline) {
|
|
list($file, $line, $where) = array_merge(
|
|
explode('@', $traceline),
|
|
array('?', '?', '?'));
|
|
if ($where == 'DarkConsole->addError' ||
|
|
$where == 'debug_rlog') {
|
|
unset($trace[$idx]);
|
|
}
|
|
}
|
|
|
|
$row->appendChild(<th rowspan={count($trace)}>{$text}</th>);
|
|
|
|
foreach ($trace as $traceline) {
|
|
list($file, $line, $where) = array_merge(
|
|
explode('@', $traceline),
|
|
array('?', '?', '?'));
|
|
$row->appendChild(<td>{$file}:{$line}</td>);
|
|
$row->appendChild(<td>{$where}()</td>);
|
|
$markup->appendChild($row);
|
|
$row = <tr class={$alt ? 'alt' : null} />;
|
|
}
|
|
|
|
$alt = !$alt;
|
|
}
|
|
|
|
return
|
|
<x:frag>
|
|
<h1>Errors</h1>
|
|
<div class="LConsoleErrors">{$markup}</div>
|
|
</x:frag>;
|
|
*/
|