mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
114ed6c7fe
Summary:
This accomplishes three major goals:
# Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole.
# Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down.
# Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff.
Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader).
Test Plan:
{F30675}
- Switched between requests and tabs, reloaded page, saw same tab.
- Used "analyze queries", "profile page", triggered errors.
- Verified page does not load anything by default if dark console is closed with Charles.
- Generally banged on it a bit.
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4692
101 lines
2.1 KiB
PHP
101 lines
2.1 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group console
|
|
*/
|
|
final class DarkConsoleEventPlugin extends DarkConsolePlugin {
|
|
|
|
public function getName() {
|
|
return 'Events';
|
|
}
|
|
|
|
public function getDescription() {
|
|
return 'Information about Phabricator events and event listeners.';
|
|
}
|
|
|
|
public function generateData() {
|
|
|
|
$listeners = PhutilEventEngine::getInstance()->getAllListeners();
|
|
foreach ($listeners as $key => $listener) {
|
|
$listeners[$key] = array(
|
|
'id' => $listener->getListenerID(),
|
|
'class' => get_class($listener),
|
|
);
|
|
}
|
|
|
|
$events = DarkConsoleEventPluginAPI::getEvents();
|
|
foreach ($events as $key => $event) {
|
|
$events[$key] = array(
|
|
'type' => $event->getType(),
|
|
'stopped' => $event->isStopped(),
|
|
);
|
|
}
|
|
|
|
return array(
|
|
'listeners' => $listeners,
|
|
'events' => $events,
|
|
);
|
|
}
|
|
|
|
public function renderPanel() {
|
|
$data = $this->getData();
|
|
|
|
$out = array();
|
|
|
|
$out[] =
|
|
'<div class="dark-console-panel-header">'.
|
|
'<h1>Registered Event Listeners</h1>'.
|
|
'</div>';
|
|
|
|
$rows = array();
|
|
foreach ($data['listeners'] as $listener) {
|
|
$rows[] = array(
|
|
phutil_escape_html($listener['id']),
|
|
phutil_escape_html($listener['class']),
|
|
);
|
|
}
|
|
|
|
$table = new AphrontTableView($rows);
|
|
$table->setHeaders(
|
|
array(
|
|
'Internal ID',
|
|
'Listener Class',
|
|
));
|
|
$table->setColumnClasses(
|
|
array(
|
|
'',
|
|
'wide',
|
|
));
|
|
|
|
$out[] = $table->render();
|
|
|
|
$out[] =
|
|
'<div class="dark-console-panel-header">'.
|
|
'<h1>Event Log</h1>'.
|
|
'</div>';
|
|
|
|
$rows = array();
|
|
foreach ($data['events'] as $event) {
|
|
$rows[] = array(
|
|
phutil_escape_html($event['type']),
|
|
$event['stopped'] ? 'STOPPED' : null,
|
|
);
|
|
}
|
|
|
|
$table = new AphrontTableView($rows);
|
|
$table->setColumnClasses(
|
|
array(
|
|
'wide',
|
|
));
|
|
$table->setHeaders(
|
|
array(
|
|
'Event Type',
|
|
'Stopped',
|
|
));
|
|
|
|
$out[] = $table->render();
|
|
|
|
|
|
return implode("\n", $out);
|
|
}
|
|
}
|