mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-20 01:08:50 +02:00
114ed6c7fe
Summary:
This accomplishes three major goals:
# Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole.
# Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down.
# Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff.
Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader).
Test Plan:
{F30675}
- Switched between requests and tabs, reloaded page, saw same tab.
- Used "analyze queries", "profile page", triggered errors.
- Verified page does not load anything by default if dark console is closed with Charles.
- Generally banged on it a bit.
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4692
|
||
|---|---|---|
| .. | ||
| attached-file-view.css | ||
| calendar-view.css | ||
| context-bar.css | ||
| crumbs-view.css | ||
| dark-console.css | ||
| dialog-view.css | ||
| error-view.css | ||
| form-view.css | ||
| headsup-action-list-view.css | ||
| headsup.css | ||
| lightbox-attachment.css | ||
| list-filter-view.css | ||
| notification.css | ||
| pager-view.css | ||
| panel-view.css | ||
| phabricator-nav-view.css | ||
| request-failure-view.css | ||
| table-view.css | ||
| tokenizer.css | ||
| tooltip.css | ||
| transaction.css | ||
| typeahead.css | ||