1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 08:20:57 +01:00
phorge-phorge/src
epriestley 119c2b8cec Fix differential.getdiff, etc., for diffs with no Arcanist Project
Summary:
`getArcanistProjectName()` has some logic which gets messy with the `self::ATTACHABLE` mechanism. This makes `differential.getdiff` and similar Conduit methods throw an exception when querying a diff which doesn't have a project. See <http://pastebin.com/Czzrd0Jz>.

Instead, unconditionally attach a project (possibly `null`) when loading diffs if they need projects.

Test Plan: Ran `differential.getdiff` against a `arc diff --raw` diff with no project, got a result instead of an exception.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, sttwister

Differential Revision: https://secure.phabricator.com/D7101
2013-09-24 10:48:40 -07:00
..
aphront Fix an issue with darkconsole.always-on and logged-out users 2013-09-05 11:16:32 -07:00
applications Fix differential.getdiff, etc., for diffs with no Arcanist Project 2013-09-24 10:48:40 -07:00
docs Convert maniphest to use standard fields 2013-09-19 11:56:15 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Route task merges through new editor 2013-09-23 14:32:32 -07:00
view ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
__celerity_resource_map__.php ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Add new-style transaction editor to Maniphest and switch priority edits to it 2013-09-23 14:31:47 -07:00