1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/drydock
epriestley 2e36653965 Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator
Summary:
Ref T2543. These are currently numeric values, like "0" and "3". I want to replace them with strings, like "accepted", and move definitions from Arcanist to Phabricator.

To set the stage for this, reduce the number of callsites where Phabricator invokes `ArcanistDifferentialRevisionStatus`.

This is just the easy ones. I'll hold this until the release cut.

Test Plan:
- Called `differential.find`.
- Called `differential.getrevision`.
- Called `differential.query`.
- Removed all reviewers from a revision, saw warning.
- Abandoned the no-reviewers revision, no more warning.
- Attached a revision to a task to get it to show the state icon with the status on a tooltip.
- Viewed revision bucketing on dashboard.
- Used `bin/search index` to reindex a revision.
- Hit the "Land Revision" endpoint.

I didn't explicitly test these cases:

  - Doorkeeper Asana integration, since setup takes a thousand years.
  - Disambiguation logic when multiple hashes match, since setup is also very involved.
  - Releeph because it's Releeph.

Reviewers: chad

Reviewed By: chad

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18339
2017-08-09 11:04:52 -07:00
..
application Unprototype Drydock 2016-03-04 17:23:07 -08:00
blueprint Improve Drydock errors for empty commits and missing changes 2016-03-07 05:29:25 -08:00
capability Give Drydock resources a proper expiry mechanism 2015-09-28 09:35:14 -07:00
conduit Expose Drydock blueprints via Conduit 2016-10-13 20:48:24 +00:00
constants Modernize Drydock SearchEngine implementations 2015-09-24 09:56:49 -07:00
controller Fix getIcon calls in PHUIObjectListItem 2016-08-19 09:35:09 -07:00
customfield Convert DrydockBlueprints to EditEngine 2016-03-03 15:21:25 -08:00
editor Update EditEngine for two column 2016-03-28 09:18:55 -07:00
exception Improve Drydock errors for empty commits and missing changes 2016-03-07 05:29:25 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
interface Make WorkingCopyBlueprint responsible for performing merges 2015-10-26 12:40:16 -07:00
logtype Make Drydock reclaim unused resources when it reaches a resource limit 2015-12-18 11:55:51 -08:00
management Fix 4 typos in code 2017-04-07 04:09:56 -07:00
operation Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Expose Drydock authorizations via Conduit 2016-10-11 19:55:43 +00:00
storage Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
typeahead Render browse results with global result style 2016-06-20 16:49:02 -07:00
view Convert Drydock to two column layout 2016-03-13 08:10:36 -07:00
worker When the push phase of "Land Revision" fails, show the error in the UI 2016-02-26 09:38:39 -08:00