1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/owners
epriestley 156b156e77 Give Conduit params/return/errors protected visibility
Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:
  - Ran `arc unit --everything`.
  - Called `conduit.query`.
  - Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380
2015-04-13 11:58:35 -07:00
..
application Allow applications to have multiple "help" menu items 2015-04-01 11:51:48 -07:00
conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
config Remove all application-specific reply handler class overrides 2015-03-31 17:22:01 -07:00
controller Provide "builtin" high-level result orders 2015-04-13 11:58:34 -07:00
editor Policy - move some owners code into an editor class and check policy better 2015-02-03 11:41:15 -08:00
mail Remove all application-specific reply handler class overrides 2015-03-31 17:22:01 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
storage Policy - move some owners code into an editor class and check policy better 2015-02-03 11:41:15 -08:00
typeahead Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00