1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/repository
epriestley 156b156e77 Give Conduit params/return/errors protected visibility
Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:
  - Ran `arc unit --everything`.
  - Called `conduit.query`.
  - Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380
2015-04-13 11:58:35 -07:00
..
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
constants Fix Mercurial command injection vulnerability 2015-03-20 09:26:32 -07:00
controller Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
daemon Only increment status message cursor if we're going to consume the message 2015-02-18 12:53:37 -08:00
data Fix pht method calls 2015-02-10 18:57:45 +11:00
editor Modernize remaining edge types 2015-01-03 10:58:20 +11:00
engine Provide TERM=dumb for Mercurial commit hooks 2015-03-30 13:02:43 -07:00
graphcache Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
mail Remove all application-specific reply handler domains 2015-03-31 16:48:40 -07:00
management Enforce that global locks have keys shorter than 64 characters 2015-04-02 13:42:22 -07:00
phid Fix some linter violations 2015-01-03 09:11:41 +11:00
query Provide "builtin" high-level result orders 2015-04-13 11:58:34 -07:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Diffusion - make projects work properly with commits 2014-11-19 14:43:59 -08:00
storage Set "importing" flag on repositories created via API 2015-03-04 10:36:09 -08:00
worker Fix a missing parameter 2015-03-02 08:15:02 +11:00