1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/src/applications/diffusion
epriestley 20ce1a905f Replace AphrontUsageException with AphrontMalformedRequestException
Summary:
Ref T1806. Ref T7173. Context here is that I want to fix "you can not log in to this instance" being a confusing mess with an opaque error. To do this without hacks, I want to:

  - clean up some exception handling behavior (this diff);
  - modularize exception handling (next diff);
  - replace confusing, over-general exceptions with tailored ones in the Phacility cluster, using the new modular stuff.

This cleans up an awkward "AphrontUsageException" which does some weird stuff right now. In particular, it is extensible and extended in one place in Diffusion, but that extension is meaningless.

Realign this as "AphrontMalformedRequestException", which is a better description of what it is and does: raises errors before we can get as far as normal routing and site handling.

Test Plan: Hit some of these exceptions, saw the expected "abandon all hope" error page.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T1806, T7173

Differential Revision: https://secure.phabricator.com/D14047
2015-09-03 10:04:17 -07:00
..
application Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Reduce badness in viewing large files in the Diffusion web UI 2015-06-18 13:06:01 -07:00
config Improve UX for Diffusion mail fields 2015-05-25 07:18:48 -07:00
controller Fix abrupt failure mode for uncloned repositories in Diffusion 2015-09-03 10:03:31 -07:00
data Extend from Phobject 2015-06-15 18:02:27 +10:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
engine Modularize the Diffusion/Differential "Block" Herald actions 2015-08-03 14:33:28 -07:00
events Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
exception Replace AphrontUsageException with AphrontMalformedRequestException 2015-09-03 10:04:17 -07:00
herald Fix an issue with "packages(...)" in typeaheads 2015-09-01 15:35:25 -07:00
panel Add "Mailing List" users 2015-06-03 18:42:33 -07:00
protocol Extend from Phobject 2015-06-15 18:02:27 +10:00
query Modernize Audit search engine 2015-08-31 10:17:54 -07:00
remarkup make repo callsigns optional 2015-01-01 08:07:26 -08:00
request Extend from Phobject 2015-06-15 18:02:27 +10:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Extend from Phobject 2015-06-15 18:02:27 +10:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Modernize Audit search engine 2015-08-31 10:17:54 -07:00
view Convert commits to use unified table of contents 2015-08-15 12:57:20 -07:00
DiffusionLintSaveRunner.php Extend from Phobject 2015-06-15 18:02:27 +10:00