mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-19 03:50:54 +01:00
No description
15e71e9bf4
Summary: Currently if I go to leave an inline comment and then decide against it and hit <tab>-<enter>, the inline comment edit dialog closes but the overlay doesn't disappear due to a JS error around trying to access the markup property of null. This fixes that by setting the payload to an array with empty markup so that the JS works and the overlay disappears. Test Plan: clicked on the line number column, then pressed ok and confirmed the dialog closed, the overlay disappeared and there were no JS errors. also tested that for clicking the reply link and when editing an existing inline comment. Reviewed By: aran Reviewers: epriestley, aran CC: aran, bh Revert Plan: OK Differential Revision: 154 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| README | ||
PROJECT STATUS: CAVEAT EMPTOR This is an unstable preview release. I'm open sourcing some of Facebook's internal tools, but they'll be unstable for probably at least a couple months. -epriestley WHAT IS PHABRICATOR? Phabricator is a suite of web applications that facilitate software development tasks, particularly code review. The primary application in the suite is Differential, a code review tool. Phabricator is highly unstable and has many missing features! These applications are being brought over from Facebook's internal toolset, but there's a lot of stuff that hasn't made it over yet. Feel free to follow the project but you probably shouldn't try to install this yet unless you're extremely ambitious or just want to take a look at it. I'm opening it up now mostly to make it easier for me to do test deployments outside of Facebook.