1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/differential/controller
epriestley 5a158b5b19 Move revision header warnings into custom fields
Summary:
Ref T5495. We currently show one warning in revision headers, about not having any reviewers.

I want to add a second warning (for missing Legalpad signatures). At least one install would like to add custom warnings (see T5495) which are so specific that we can't reasonably cover them in the upstream.

Generalize these header warnings by moving them to CustomField, so I can implement the Legalpad stuff without making a mess and the install in T5495 can use an extension.

Test Plan:
Hit all three header states, they look exactly like they did before this change:

{F173265}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5495

Differential Revision: https://secure.phabricator.com/D9793
2014-07-02 04:58:51 -07:00
..
DifferentialChangesetViewController.php Set device to false for all pages which don't specify device readiness 2014-06-23 15:15:11 -07:00
DifferentialCommentPreviewController.php Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
DifferentialCommentSaveController.php Use TransactionEditor in differential.createcomment 2014-03-07 17:44:10 -08:00
DifferentialController.php Replace Sprite-Icons with FontAwesome 2014-05-12 10:08:32 -07:00
DifferentialDiffCreateController.php Remove all device = true from page construction 2014-06-23 15:18:14 -07:00
DifferentialDiffViewController.php Remove all device = true from page construction 2014-06-23 15:18:14 -07:00
DifferentialInlineCommentEditController.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
DifferentialInlineCommentPreviewController.php Abstract access to DifferentialInlineComment behind a Query 2013-06-21 12:54:56 -07:00
DifferentialRevisionEditController.php Remove all device = true from page construction 2014-06-23 15:18:14 -07:00
DifferentialRevisionLandController.php make "Land to..." button call diffusion.looksoon 2014-06-22 12:30:50 -07:00
DifferentialRevisionListController.php Move a bunch more rendering into SearchEngine 2014-05-08 20:04:19 -07:00
DifferentialRevisionViewController.php Move revision header warnings into custom fields 2014-07-02 04:58:51 -07:00