1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/herald/storage
epriestley 181bfffaa1 Truncate object fields in Herald transcripts
Summary:
A few users have hit cases where Herald transcripts of large commits exceed the MySQL packet limit, because one of the fields in the transcript is an enomrous textual diff.

There's no value in saving these huge amounts of data. Transcripts are useful for understanding the action of Herald rules, but can be reconstructed later. Instead of saving all of the data, limit each field to 4KB of data.

For strings, we just truncate at 4KB. For arrays, we truncate after 4KB of values.

Test Plan: Ran unit tests. Artificially decreased limit and ran transcripts, saw them truncate properly.

Reviewers: btrahan

Reviewed By: btrahan

CC: frgtn, aran

Differential Revision: https://secure.phabricator.com/D7783
2013-12-18 11:59:53 -08:00
..
__tests__ Truncate object fields in Herald transcripts 2013-12-18 11:59:53 -08:00
transcript Truncate object fields in Herald transcripts 2013-12-18 11:59:53 -08:00
HeraldAction.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldCondition.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldRule.php Add Herald support for blocking ref changes 2013-12-17 15:23:55 -08:00
HeraldRuleEdit.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldRuleTransaction.php Allow Herald rules to be disabled, instead of deleted 2013-10-06 17:10:29 -07:00
HeraldRuleTransactionComment.php Add ApplicationTransactions to Herald 2013-08-07 18:03:49 -07:00