revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/herald/controller
History
epriestley 19662e33bc In Herald transcript rendering, don't store display labels in keys 
Summary:
Ref T13480. Currently, when Herald renders a transcript, it puts display labels into array keys. This is a bad pattern for several reasons, notably that the values must be scalar (so you can't add icons or other markup later) and the values must be unique (which is easily violated because many values are translated).

Instead, keep values as list items.

Test Plan: Viewed Herald transcripts, saw no (meaningful) change in rendering output.

Maniphest Tasks: T13480

Differential Revision: https://secure.phabricator.com/D20949
2020-01-29 15:11:41 -08:00
..
HeraldController.php Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
HeraldDisableController.php Modularize HeraldRule transactions 2019-03-07 11:55:31 -08:00
HeraldNewController.php Replace "URI->setQueryParams()" after initialization with a constructor argument 2019-02-14 11:46:37 -08:00
HeraldRuleController.php Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
HeraldRuleListController.php Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
HeraldRuleViewController.php Remove legacy pre-loading of handles from Herald rendering 2020-01-29 15:07:23 -08:00
HeraldTestConsoleController.php In the Herald test console, don't consider transactions that Herald rules applied 2019-05-22 16:34:34 -07:00
HeraldTranscriptController.php In Herald transcript rendering, don't store display labels in keys 2020-01-29 15:11:41 -08:00
HeraldTranscriptListController.php Modernize Herald 2015-11-30 07:11:52 -08:00
HeraldWebhookController.php Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
HeraldWebhookEditController.php Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
HeraldWebhookKeyController.php Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
HeraldWebhookListController.php Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
HeraldWebhookTestController.php Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
HeraldWebhookViewController.php Index "Call Webhook" in Herald, and show calling rules on the Webhook page 2019-03-07 14:48:14 -08:00