mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
No description
1970ceefe3
Summary: The final goal is to display reviewers response time on homepage. This is a building block for it. The algorithm is quite strict - it doesn't count simple comment as response because reviewers would be able to cheat with comments like "I'm overwhelmed right now and will review next week". We are more liberate in Phabricator where reviewers response with comments without changing the status quite often but I'm not trying to improve response times in Phabricator so this is irrelevant. Reviewers in Facebook changes status more often (to clean their queue) so I follow this approach. There is currently no way to track reviewers silently added and removed in Edit Revision but it's not a big deal. The algorithm doesn't track commandeered revision, there's a TODO for it. Response times are put in two buckets: `$reviewed` and `$not_reviewed`. `$reviewed` contains reviewers who took action, `$not_reviewed` contains reviewers who didn't respond on time. I will probably compute average time from `$reviewed` and raise it for those `$not_reviewed` that are higher than this average. The idea is to not favor reviewers who were only lucky for being in a group with someone fast. Test Plan: Passed test. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3062 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support/aphlict | ||
| webroot | ||
| .arcconfig | ||
| .divinerconfig | ||
| .gitignore | ||
| .gitmodules | ||
| README | ||
Phabricator is a open source collection of web applications which make it easier to write, review, and share source code. Phabricator was developed at Facebook. This is an early release. It's pretty high-quality and usable, but under active development so things may change quickly. You can learn more about the project and find links to documentation and resources at: http://phabricator.org/ LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted. http://www.apache.org/licenses/LICENSE-2.0