mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 18:22:41 +01:00
19d9da7fea
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. So, we adopt an explicit cast to string in order to answer the question "Is this a non-empty string?" without relying on implicit cast and deprecated things. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_string_cast() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15409 Test Plan: Applied this change and afterwards, selecting "Working Copy" on `/drydock/blueprint/edit/form/default/` does not show a RuntimeException on strlen() anymore. Instead, it shows a PhutilAggregateException covered in T15408. Try also creating an integer "Custom Field" in some applications like Maniphest (maniphest.custom-field-definitions) or in the People component (user.custom-field-definitions) etc., populating the related forms with your usual fuzzy tests. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15409 Differential Revision: https://we.phorge.it/D25235 |
||
|---|---|---|
| .. | ||
| cache | ||
| cluster | ||
| contentsource | ||
| customfield | ||
| daemon | ||
| diff | ||
| edges | ||
| editor | ||
| env | ||
| events | ||
| export | ||
| graph | ||
| internationalization | ||
| javelin | ||
| lint/linter | ||
| lipsum | ||
| log | ||
| management | ||
| markup | ||
| parser | ||
| query | ||
| ssh | ||
| status | ||
| storage | ||
| syntax | ||
| testing | ||
| time | ||
| util | ||
| PhabricatorEditor.php | ||