mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
1a3ac09975
Summary: Ref T3551. Currently, ReleephRequests don't have a direct concept of the //object// being requested. You can request `D123`, but that is just a convenient way to write `rXyyyy`. When the UI wants to display information about a revision, it deduces it by examining the commit. This is primarily an attack on T3551, so we don't need to load <commit -> edge -> revision> (in an ad-hoc way) to get revisions. Instead, when you request a revision we keep track of it and can load it directly later. Later, this will let us do more things: for example, if you request a branch, we can automatically update the commits (as GitHub does), etc. (Repository branches will need PHIDs first, of course.) This adds and populates the column but doesn't use it yet. The second part of the migration could safely be run while Phabricator is up, although even for Facebook this table is probably quite small. Test Plan: - Ran migration. - Verified existing requests associated sensibly. - Created a new commit request. - Created a new revision request. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3551 Differential Revision: https://secure.phabricator.com/D8822
45 lines
1.1 KiB
PHP
45 lines
1.1 KiB
PHP
<?php
|
|
|
|
$pull_table = new ReleephRequest();
|
|
$table_name = $pull_table->getTableName();
|
|
$conn_w = $pull_table->establishConnection('w');
|
|
|
|
echo "Setting object PHIDs for requests...\n";
|
|
foreach (new LiskMigrationIterator($pull_table) as $pull) {
|
|
$id = $pull->getID();
|
|
|
|
echo "Migrating pull request {$id}...\n";
|
|
if ($pull->getRequestedObjectPHID()) {
|
|
// We already have a valid PHID, so skip this request.
|
|
continue;
|
|
}
|
|
|
|
$commit_phids = $pull->getCommitPHIDs();
|
|
if (count($commit_phids) != 1) {
|
|
// At the time this migration was written, all requests had exactly one
|
|
// commit. If a request has more than one, we don't have the information
|
|
// we need to process it.
|
|
continue;
|
|
}
|
|
|
|
$commit_phid = head($commit_phids);
|
|
|
|
$revision_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
|
|
$commit_phid,
|
|
PhabricatorEdgeConfig::TYPE_COMMIT_HAS_DREV);
|
|
|
|
if ($revision_phids) {
|
|
$object_phid = head($revision_phids);
|
|
} else {
|
|
$object_phid = $commit_phid;
|
|
}
|
|
|
|
queryfx(
|
|
$conn_w,
|
|
'UPDATE %T SET requestedObjectPHID = %s WHERE id = %d',
|
|
$table_name,
|
|
$object_phid,
|
|
$id);
|
|
}
|
|
|
|
echo "Done.\n";
|