1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/phid
Anh Nhan Nguyen f95710e799 Consolidate Macro loading
Summary:
Fixes T2820

Grepped for `PhabricatorFileImageMacro`, a common approach to load image macros from storage. Cleaned up file loading too (in most cases where I could be sure that I won't break anything).

Did not touch the `add_macro.php` util script, since many users will assume the user `ubuntu` or `ec2-user` to run the script. Add no sessions and no CSRF protection measures...

Test Plan:
Browsed around all kinds of places. Created and looked at memes, created and edited macros. Used them in Remarkup (with flushed cache). Used `macro.query`, verified it did not crash (that's always a good sign).

Could not verify object handles, since I have no idea where they appear right now.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2820

Differential Revision: https://secure.phabricator.com/D5418
2013-03-22 13:07:20 -07:00
..
application Implement very basic uberhome 2013-01-15 15:41:22 -08:00
conduit Uninstall Conduit calls when uninstalling applications 2013-03-13 07:09:05 -07:00
config Formalize phid.external-loaders 2013-01-19 10:20:24 -08:00
controller Display full handle name in PHID lookup 2013-03-13 00:55:07 -07:00
handle Consolidate Macro loading 2013-03-22 13:07:20 -07:00
storage Support "M" in phid.lookup and ircbot 2013-03-05 12:31:52 -08:00
PhabricatorObjectHandle.php Render commit summaries when rendering handles 2013-02-21 15:09:35 -08:00
PhabricatorPHIDConstants.php Phlux v0 2013-03-20 18:01:52 -07:00
utils.php Add feed integration to generic transactions 2012-12-11 14:00:21 -08:00