1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/people
Gregor Stocks cd9d59344c Fix a rap bug, and add a beat
Summary:
The flow was off in some cases. This should mitigate it.

Adds a Unicode musical note character at the start of the rap which,
when clicked, embeds a song in the background, hides it and plays it.
Currently the song is Gangsta's Paradise (karaoke version) but if you'd
prefer a different song, I can probably change it with only a few weeks
of work.

This doesn't respect the "embed youtubes" preference because you have to
click something to embed it, so it's your own fault your referers are
getting leaked.

For now, does the simplest thing and doesn't loop it. If it turns out
people are spending a lot of time on this page, we should look into
doing something like youtuberepeater.

Not trying to make this share code with the existing Youtube embedding
stuff - I think they're doing different enough things that solving them
both in the same way would be more code.

Test Plan:
Clicked the note in Firefox. Clicked the note in Chrome.
Considered clicking the note in Safari and Internet Explorer.

Reviewers: epriestley

Reviewed By: epriestley

CC: miorel, HarrisonW, aran, Korvin

Differential Revision: https://secure.phabricator.com/D4437
2013-01-15 10:32:49 -08:00
..
application Use application icons for "Eye" menu and Crumbs 2012-12-07 13:37:28 -08:00
conduit Fix displaying of user status 2012-12-21 16:30:36 -08:00
controller Remove spacer from sidebars. 2013-01-13 08:17:12 -08:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
search Improve Search architecture 2012-12-21 14:21:31 -08:00
storage Fix a rap bug, and add a beat 2013-01-15 10:32:49 -08:00
PhabricatorPeopleQuery.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorUserEditor.php Delete license headers from files 2012-11-05 11:16:51 -08:00