1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-28 06:29:27 +01:00
phorge-phorge/src/applications/pholio
Andre Klapper 1b4015d2c1 Fix PHP 8.1 "strlen(null)" exception which blocks rendering Pholio mock preview
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15353

Test Plan: Applied this change and `/pholio/create/` displayed an image preview after uploading an image file.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15353

Differential Revision: https://we.phorge.it/D25193
2023-05-07 12:37:00 +02:00
..
application Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
controller Fix PHP 8.1 "strlen(null)" exception which blocks rendering Pholio mock preview 2023-05-07 12:37:00 +02:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engine Reduce the amount of weird "static" and "cache" behavior in Pholio query classes 2018-12-20 15:32:13 -08:00
herald Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
lipsum Make Images in Pholio refer to mocks by PHID instead of ID 2018-12-20 14:54:25 -08:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
phid Make Images in Pholio refer to mocks by PHID instead of ID 2018-12-20 14:54:25 -08:00
query Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Fix an issue with {M13} and Spaces 2015-06-13 06:54:02 -07:00
search Support Ferret engine in Pholio 2017-09-07 13:25:29 -07:00
storage Fix an out-of-date API call on the destruction pathway for Pholio mocks 2020-04-10 08:01:34 -07:00
view Fix "add more metadata" fatal in Pholio 2019-07-11 15:55:56 -07:00
xaction Fix broken file PHID extraction that causes Pholio uploads to crash 2022-11-11 13:10:16 -07:00