1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 09:22:40 +01:00
phorge-phorge/src/applications/harbormaster/step
epriestley 1bdf225354 Use Drydock authorizations when acquiring leases
Summary:
Ref T9519. When acquiring leases on resources:

  - Only consider resources created by authorized blueprints.
  - Only consider authorized blueprints when creating new resources.
  - Fail with a tailored error if no blueprints are allowed.
  - Fail with a tailored error if missing authorizations are causing acquisition failure.

One somewhat-substantial issue with this is that it's pretty hard to figure out from the Harbormaster side. Specifically, the Build step UI does not show field value anywhere, so the presence of unapproved blueprints is not communicated. This is much more clear in Drydock. I'll plan to address this in future changes to Harbormaster, since there are other related/similar issues anyway.

Test Plan: {F872527}

Reviewers: hach-que, chad

Reviewed By: chad

Maniphest Tasks: T9519

Differential Revision: https://secure.phabricator.com/D14254
2015-10-12 17:02:35 -07:00
..
__tests__ Add a bunch of tests for subclass implementations 2015-06-15 18:13:27 +10:00
HarbormasterArcLintBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterArcUnitBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterBuildStepImplementation.php Allow builds to have parameters 2015-10-02 06:32:08 -07:00
HarbormasterCommandBuildStepImplementation.php Probably fix bad loadArtifactLease() call 2015-08-18 10:46:41 -07:00
HarbormasterDrydockCommandBuildStepImplementation.php Put Drydock build steps into their own group in Harbormaster 2015-10-05 15:59:35 -07:00
HarbormasterHTTPRequestBuildStepImplementation.php Acccept any HTTP 2xx status as success in Harbormaster 2015-10-02 09:17:51 -07:00
HarbormasterLeaseHostBuildStepImplementation.php Associate Harbormaster build target with leases 2015-08-24 17:20:59 +10:00
HarbormasterLeaseWorkingCopyBuildStepImplementation.php Use Drydock authorizations when acquiring leases 2015-10-12 17:02:35 -07:00
HarbormasterPublishFragmentBuildStepImplementation.php Add harbormaster.createartifact 2015-08-15 07:28:56 -07:00
HarbormasterSleepBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterThrowExceptionBuildStep.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterUploadArtifactBuildStepImplementation.php Remove call to loadDrydockLease 2015-08-18 17:52:55 -07:00
HarbormasterWaitForPreviousBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00