1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src
epriestley 1bf64e5cbc Add Differential and Herald mail stamps and some refinements
Summary:
Ref T13053. Adds revision stamps (status, reviewers, etc). Adds Herald rule stamps, like the existing X-Herald-Rules header.

Removes the "self" stamps, since you can just write a rule against `whatever(@epriestley)` equivalently. If there's routing logic around this, it can live in the routing layer. This avoids tons of self-actor, self-mention, self-reviewer, self-blocking-reviewer, self-resigned-reviewer, etc., stamps.

Use `natcasesort()` instead of `sort()` so that numeric values (like monograms) sort `9, 80, 700` instead of `700, 80, 9`.

Remove the commas from rendering since they don't really add anything.

Test Plan: Edited tasks and revisions, looked at mail stamps, saw stamps that looked pretty reasonable (with no more self stuff, no more commas, sorting numbers, and Herald stamps).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13053

Differential Revision: https://secure.phabricator.com/D18997
2018-02-06 04:06:07 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Modularize rate/connection limits in Phabricator 2017-10-13 13:12:05 -07:00
applications Add Differential and Herald mail stamps and some refinements 2018-02-06 04:06:07 -08:00
docs Document the new "only if this didn't match last time" Herald action setting 2018-01-26 11:06:43 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Allow revisions to revert commits and one another, and commits to revert revisions 2018-02-02 08:25:58 -08:00
view Fix a possible count(null) in PHUIInfoView 2018-01-29 15:16:41 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Add Differential and Herald mail stamps and some refinements 2018-02-06 04:06:07 -08:00