mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-26 23:40:57 +01:00
29d8fc04e5
Summary: - When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page. - In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews. Test Plan: - Viewed visible and not-visible inline comment previews, clicked "View" links. - Tapped "z" a bunch to toggle haunt modes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T517, T214 Differential Revision: https://secure.phabricator.com/D2041
82 lines
2.2 KiB
JavaScript
82 lines
2.2 KiB
JavaScript
/**
|
|
* @provides javelin-behavior-differential-feedback-preview
|
|
* @requires javelin-behavior
|
|
* javelin-stratcom
|
|
* javelin-dom
|
|
* javelin-request
|
|
* javelin-util
|
|
* phabricator-shaped-request
|
|
*/
|
|
|
|
JX.behavior('differential-feedback-preview', function(config) {
|
|
|
|
var action = JX.$(config.action);
|
|
var content = JX.$(config.content);
|
|
var previewTokenizers = {};
|
|
for (var field in config.previewTokenizers) {
|
|
var tokenizer = JX.$(config.previewTokenizers[field]);
|
|
previewTokenizers[field] = JX.Stratcom.getData(tokenizer).tokenizer;
|
|
}
|
|
|
|
var callback = function(r) {
|
|
JX.DOM.setContent(JX.$(config.preview), JX.$H(r));
|
|
};
|
|
|
|
var getdata = function() {
|
|
var data = {
|
|
content : content.value,
|
|
action : action.value
|
|
};
|
|
for (var field in previewTokenizers) {
|
|
data[field] = JX.keys(previewTokenizers[field].getTokens()).join(',');
|
|
}
|
|
return data;
|
|
};
|
|
|
|
var request = new JX.PhabricatorShapedRequest(config.uri, callback, getdata);
|
|
var trigger = JX.bind(request, request.trigger);
|
|
|
|
JX.DOM.listen(content, 'keydown', null, trigger);
|
|
JX.DOM.listen(action, 'change', null, trigger);
|
|
for (var field in previewTokenizers) {
|
|
previewTokenizers[field].listen('change', trigger);
|
|
}
|
|
|
|
request.start();
|
|
|
|
|
|
function refreshInlinePreview() {
|
|
new JX.Request(config.inlineuri, function(r) {
|
|
var inline = JX.$(config.inline);
|
|
|
|
JX.DOM.setContent(inline, JX.$H(r));
|
|
|
|
// Go through the previews and activate any "View" links where the
|
|
// actual comment appears in the document.
|
|
|
|
var links = JX.DOM.scry(
|
|
inline,
|
|
'a',
|
|
'differential-inline-preview-jump');
|
|
for (var ii = 0; ii < links.length; ii++) {
|
|
var data = JX.Stratcom.getData(links[ii]);
|
|
try {
|
|
JX.$(data.anchor);
|
|
links[ii].href = '#' + data.anchor;
|
|
JX.DOM.setContent(links[ii], 'View');
|
|
} catch (ignored) {
|
|
// This inline comment isn't visible, e.g. on some other diff.
|
|
}
|
|
}
|
|
})
|
|
.setTimeout(5000)
|
|
.send();
|
|
}
|
|
|
|
JX.Stratcom.listen(
|
|
'differential-inline-comment-update',
|
|
null,
|
|
refreshInlinePreview);
|
|
|
|
refreshInlinePreview();
|
|
});
|