1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/audit
epriestley 1cda1402c7 Do not publish/notify about commits which are not reachable from any "Autoclose" ref
Summary:
Depends on D20418. Ref T13277. Fixes T11314.

Currently, when you push commits to some arbitrary ref or tag (like `refs/pull/123` on GitHub, `refs/tags/phabricator/diff/123` on Phabricator, or `refs/changes/whatever` on Gerrit), we do not "autoclose" related objects. This means that we don't process `Ref T123` to create links to tasks, and don't process `Differential Revision: xyz` to close revisions.

However, we //do// still publish these commits. "Publish" means: trigger audits, publish feed stories, and run Herald rules.

  - Stop publishing these commits.
  - In the UI, show these commits as "Not Permanent" with a note that they are "Not [on any permanent branch]."

These commits will publish and autoclose if they ever become reachable from an "autoclose" ref (most commonly, if they are later merged to "master").

Test Plan:
  - Pushed a commit to `refs/tags/quack`.
  - Before: got a feed story.
  - After: no feed story, UI shows commit as "Not Permanent".

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13277, T11314

Differential Revision: https://secure.phabricator.com/D20419
2019-04-18 05:05:00 -07:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
constants Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor Do not publish/notify about commits which are not reachable from any "Autoclose" ref 2019-04-18 05:05:00 -07:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
management Make "bin/audit delete" synchronize commit audit status, and improve "bin/audit synchronize" documentation 2019-02-13 05:50:14 -08:00
query Expose "identifiers" as a query constraint for Commit search 2018-11-24 07:20:01 -08:00
storage Remove "willRenderTimeline()" from ApplicationTransactionInterface 2018-12-20 14:55:07 -08:00
view Introduce an AuditStatus object for commits and move some callsites to it 2018-09-07 10:20:04 -07:00