1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 05:11:05 +01:00
phorge-phorge/src/applications/macro
epriestley c206b066df When {meme ...} embed has no text, just use the raw file data unmodified
Summary:
Ref T13216. See PHI948. When you use the remarkup hint button to embed a meme with no text, you get `{meme src=X}`.

If the source is a GIF, we currently split the source apart into frame-by-frame images, process them, and stitch them back together. The end result is the same image we started with, but this process can be slow/expensive, and may timeout for sufficiently large GIFs.

Instead: when there's no text, just return the original image data.

Test Plan:
  - Used `{meme src=X}` with no text, got an image faster.
  - Used `{meme src=X, above=...}` to add text, got an attempt to add text (which didn't get very far locally since I don't have GD configured).

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19777
2018-11-06 09:40:22 -08:00
..
application Update Macro comment form 2017-05-03 12:34:21 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit PhabricatorMemeEngine HA HA HA HA 2018-03-08 11:06:52 -08:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller PhabricatorMemeEngine HA HA HA HA 2018-03-08 11:06:52 -08:00
editor Use object PHIDs for "Thread-Topic" headers in mail 2018-02-08 06:21:00 -08:00
engine When {meme ...} embed has no text, just use the raw file data unmodified 2018-11-06 09:40:22 -08:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
markup Possibly fix memes in email 2018-03-08 11:09:21 -08:00
phid Provide an application link for the Macro PHID type 2015-10-24 09:41:13 -07:00
query Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
storage Update Macro for EditEngine 2017-05-03 11:11:23 -07:00
typeahead Add some sort of sort to Emoji Autocomplete 2017-01-24 20:21:06 -08:00
xaction Allow a wider range of characters in macro names, including emoji 2018-02-09 14:34:30 -08:00