mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-10 23:01:04 +01:00
No description
1dd1237c92
Summary: Depends on D18925. Ref T13048. Currently, HeraldRule stores policies as integers (0 or 1) in the database. The application tries to mostly use strings ("first", "every"), but doesn't do a good job of hiding the fact that the values are integers deeper in the stack. So we end up with a lot of code like this: ```lang=php $stored_int_value = $rule->getRepetitionPolicy(); $equivalent_string = HeraldRepetitionPolicyConfig::getString($stored_int_value); $is_first = ($equivalent_string === HeraldRepetitionPolicyConfig::FIRST); ``` This happens in several places and is generally awful. Replace it with: ```lang=php $is_first = $rule->isRepeatFirst(); ``` To do this, merge `HeraldRepetitionPolicyConfig` into `HeraldRule` and hide all the mess inside the methods. (This may let us just get rid of the integers in a later change, although I'm not sure I want to commit to that.) Test Plan: - Grepped for `HeraldRepetitionPolicyConfig`, no more hits. - Grepped for `setRepetitionPolicy(...)` and `getRepetitionPolicy(...)`. There are no remaining callers outside of `HeraldRule`. - Browed and edited several rules. I'll vet this more convincingly after adding the new repetition rule. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13048 Differential Revision: https://secure.phabricator.com/D18926 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.