1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/conpherence
epriestley 042ab0ad9d Fix three minor edge case behaviors in Conpherence
Summary:
Couple of tweaks:

  - If a conpherence has no participants, we fail to `attachParticipants()`. This can happen if you leave a Conpherence as the last participant, then visit the URI again explicitly.
  - If you can't load any transactions (usually, because you don't have permission to view a thread's transactions), we try to attach `null` instead of `array()`. This can happen if you attempt to view a thread you don't have permission to see. A more general fix would be to tweak the load/filtering order, but I'm leaving that for another time since it's more involved and only gives us a small performance gain in unusual sitautions.
  - `initializeNewThread()` should be declared `static`.

Test Plan:
  - Viewed a thread with no participants, got proper policy error.
  - Viewed a thread I couldn't see, got proper policy error.
  - Grepped for `initializeNewThread()`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8467
2014-03-10 16:21:28 -07:00
..
application Add app icons to quick menu 2014-01-31 15:19:39 -08:00
conduit Conpherence - add an updatethread conduit method 2013-05-31 14:58:02 -07:00
config Fix spelling blip 2013-04-03 08:27:05 -07:00
constants Conpherence - add draft support 2014-02-17 15:57:13 -08:00
controller Fix some issues where Conpherence would make to many draft requests 2014-03-01 11:23:08 -08:00
editor Maniphest Tasks + Project Boards - some polish 2014-03-04 17:01:33 -08:00
events Various linter fixes. 2014-02-26 12:44:58 -08:00
mail Fix two issues with creating Conpherence threads via mail on some configurations 2013-12-12 10:59:28 -08:00
phid Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
query Fix three minor edge case behaviors in Conpherence 2014-03-10 16:21:28 -07:00
storage Fix three minor edge case behaviors in Conpherence 2014-03-10 16:21:28 -07:00
view Conpherence - add draft support 2014-02-17 15:57:13 -08:00