mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 18:32:41 +01:00
c467cc464f
Summary: Ref T603. This swaps almost all queries against the repository table over to be policy aware. Test Plan: - Made an audit comment on a commit. - Ran `save_lint.php`. - Looked up a commit with `diffusion.getcommits`. - Looked up lint messages with `diffusion.getlintmessages`. - Clicked an external/submodule in Diffusion. - Viewed main lint and repository lint in Diffusion. - Completed and validated Owners paths in Owners. - Executed dry runs via Herald. - Queried for package owners with `owners.query`. - Viewed Owners package. - Edited Owners package. - Viewed Owners package list. - Executed `repository.query`. - Viewed "Repository" tool repository list. - Edited Arcanist project. - Hit "Delete" on repository (this just tells you to use the CLI). - Created a repository. - Edited a repository. - Ran `bin/repository list`. - Ran `bin/search index rGTESTff45d13dffcfb3ea85b03aac8cc36251cacdf01c` - Pushed and parsed a commit. - Skipped all the Drydock stuff, as it it's hard to test and isn't normally reachable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7132
291 lines
7.7 KiB
PHP
291 lines
7.7 KiB
PHP
<?php
|
|
|
|
final class DiffusionLintSaveRunner {
|
|
private $arc = 'arc';
|
|
private $severity = ArcanistLintSeverity::SEVERITY_ADVICE;
|
|
private $all = false;
|
|
private $chunkSize = 256;
|
|
private $needsBlame = false;
|
|
|
|
private $svnRoot;
|
|
private $lintCommit;
|
|
private $branch;
|
|
private $conn;
|
|
private $deletes = array();
|
|
private $inserts = array();
|
|
private $blame = array();
|
|
|
|
|
|
public function setArc($path) {
|
|
$this->arc = $path;
|
|
return $this;
|
|
}
|
|
|
|
public function setSeverity($string) {
|
|
$this->severity = $string;
|
|
return $this;
|
|
}
|
|
|
|
public function setAll($bool) {
|
|
$this->all = $bool;
|
|
return $this;
|
|
}
|
|
|
|
public function setChunkSize($number) {
|
|
$this->chunkSize = $number;
|
|
return $this;
|
|
}
|
|
|
|
public function setNeedsBlame($boolean) {
|
|
$this->needsBlame = $boolean;
|
|
return $this;
|
|
}
|
|
|
|
|
|
public function run($dir) {
|
|
$working_copy = ArcanistWorkingCopyIdentity::newFromPath($dir);
|
|
$api = ArcanistRepositoryAPI::newAPIFromWorkingCopyIdentity($working_copy);
|
|
|
|
$this->svnRoot = id(new PhutilURI($api->getSourceControlPath()))->getPath();
|
|
if ($api instanceof ArcanistGitAPI) {
|
|
$svn_fetch = $api->getGitConfig('svn-remote.svn.fetch');
|
|
list($this->svnRoot) = explode(':', $svn_fetch);
|
|
if ($this->svnRoot != '') {
|
|
$this->svnRoot = '/'.$this->svnRoot;
|
|
}
|
|
}
|
|
|
|
$project_id = $working_copy->getProjectID();
|
|
$project = id(new PhabricatorRepositoryArcanistProject())
|
|
->loadOneWhere('name = %s', $project_id);
|
|
if (!$project || !$project->getRepositoryID()) {
|
|
throw new Exception("Couldn't find repository for {$project_id}.");
|
|
}
|
|
|
|
$branch_name = $api->getBranchName();
|
|
$this->branch = new PhabricatorRepositoryBranch();
|
|
$this->conn = $this->branch->establishConnection('w');
|
|
$this->branch = $this->branch->loadOneWhere(
|
|
'repositoryID = %d AND name = %s',
|
|
$project->getRepositoryID(),
|
|
$branch_name);
|
|
|
|
$this->lintCommit = null;
|
|
if (!$this->branch) {
|
|
$this->branch = id(new PhabricatorRepositoryBranch())
|
|
->setRepositoryID($project->getRepositoryID())
|
|
->setName($branch_name)
|
|
->save();
|
|
} else if (!$this->all) {
|
|
$this->lintCommit = $this->branch->getLintCommit();
|
|
}
|
|
|
|
if ($this->lintCommit) {
|
|
try {
|
|
$commit = $this->lintCommit;
|
|
if ($this->svnRoot) {
|
|
$commit = $api->getCanonicalRevisionName('@'.$commit);
|
|
}
|
|
$all_files = $api->getChangedFiles($commit);
|
|
} catch (ArcanistCapabilityNotSupportedException $ex) {
|
|
$this->lintCommit = null;
|
|
}
|
|
}
|
|
|
|
if (!$this->lintCommit) {
|
|
$where = ($this->svnRoot
|
|
? qsprintf($this->conn, 'AND path LIKE %>', $this->svnRoot.'/')
|
|
: '');
|
|
queryfx(
|
|
$this->conn,
|
|
'DELETE FROM %T WHERE branchID = %d %Q',
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
$this->branch->getID(),
|
|
$where);
|
|
$all_files = $api->getAllFiles();
|
|
}
|
|
|
|
$count = 0;
|
|
|
|
$files = array();
|
|
foreach ($all_files as $file => $val) {
|
|
$count++;
|
|
if (!$this->lintCommit) {
|
|
$file = $val;
|
|
} else {
|
|
$this->deletes[] = $this->svnRoot.'/'.$file;
|
|
if ($val & ArcanistRepositoryAPI::FLAG_DELETED) {
|
|
continue;
|
|
}
|
|
}
|
|
$files[$file] = $file;
|
|
|
|
if (count($files) >= $this->chunkSize) {
|
|
$this->runArcLint($files);
|
|
$files = array();
|
|
}
|
|
}
|
|
|
|
$this->runArcLint($files);
|
|
$this->saveLintMessages();
|
|
|
|
$this->lintCommit = $api->getUnderlyingWorkingCopyRevision();
|
|
$this->branch->setLintCommit($this->lintCommit);
|
|
$this->branch->save();
|
|
|
|
if ($this->blame) {
|
|
$this->blameAuthors();
|
|
$this->blame = array();
|
|
}
|
|
|
|
return $count;
|
|
}
|
|
|
|
|
|
private function runArcLint(array $files) {
|
|
if (!$files) {
|
|
return;
|
|
}
|
|
|
|
echo '.';
|
|
try {
|
|
$future = new ExecFuture(
|
|
'%C lint --severity %s --output json %Ls',
|
|
$this->arc,
|
|
$this->severity,
|
|
$files);
|
|
|
|
foreach (new LinesOfALargeExecFuture($future) as $json) {
|
|
$paths = json_decode($json, true);
|
|
if (!is_array($paths)) {
|
|
fprintf(STDERR, "Invalid JSON: {$json}\n");
|
|
continue;
|
|
}
|
|
|
|
foreach ($paths as $path => $messages) {
|
|
if (!isset($files[$path])) {
|
|
continue;
|
|
}
|
|
|
|
foreach ($messages as $message) {
|
|
$line = idx($message, 'line', 0);
|
|
|
|
$this->inserts[] = qsprintf(
|
|
$this->conn,
|
|
'(%d, %s, %d, %s, %s, %s, %s)',
|
|
$this->branch->getID(),
|
|
$this->svnRoot.'/'.$path,
|
|
$line,
|
|
idx($message, 'code', ''),
|
|
idx($message, 'severity', ''),
|
|
idx($message, 'name', ''),
|
|
idx($message, 'description', ''));
|
|
|
|
if ($line && $this->needsBlame) {
|
|
$this->blame[$path][$line] = true;
|
|
}
|
|
}
|
|
|
|
if (count($this->deletes) >= 1024 || count($this->inserts) >= 256) {
|
|
$this->saveLintMessages();
|
|
}
|
|
}
|
|
}
|
|
|
|
} catch (Exception $ex) {
|
|
fprintf(STDERR, $ex->getMessage()."\n");
|
|
}
|
|
}
|
|
|
|
|
|
private function saveLintMessages() {
|
|
$this->conn->openTransaction();
|
|
|
|
foreach (array_chunk($this->deletes, 1024) as $paths) {
|
|
queryfx(
|
|
$this->conn,
|
|
'DELETE FROM %T WHERE branchID = %d AND path IN (%Ls)',
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
$this->branch->getID(),
|
|
$paths);
|
|
}
|
|
|
|
foreach (array_chunk($this->inserts, 256) as $values) {
|
|
queryfx(
|
|
$this->conn,
|
|
'INSERT INTO %T
|
|
(branchID, path, line, code, severity, name, description)
|
|
VALUES %Q',
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
implode(', ', $values));
|
|
}
|
|
|
|
$this->conn->saveTransaction();
|
|
|
|
$this->deletes = array();
|
|
$this->inserts = array();
|
|
}
|
|
|
|
|
|
private function blameAuthors() {
|
|
$repository = id(new PhabricatorRepositoryQuery())
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
->withIDs(array($this->branch->getRepositoryID()))
|
|
->executeOne();
|
|
|
|
$queries = array();
|
|
$futures = array();
|
|
foreach ($this->blame as $path => $lines) {
|
|
$drequest = DiffusionRequest::newFromDictionary(array(
|
|
'user' => PhabricatorUser::getOmnipotentUser(),
|
|
'initFromConduit' => false,
|
|
'repository' => $repository,
|
|
'branch' => $this->branch->getName(),
|
|
'path' => $path,
|
|
'commit' => $this->lintCommit,
|
|
));
|
|
$query = DiffusionFileContentQuery::newFromDiffusionRequest($drequest)
|
|
->setNeedsBlame(true);
|
|
$queries[$path] = $query;
|
|
$futures[$path] = $query->getFileContentFuture();
|
|
}
|
|
|
|
$authors = array();
|
|
|
|
foreach (Futures($futures)->limit(8) as $path => $future) {
|
|
$queries[$path]->loadFileContentFromFuture($future);
|
|
list(, $rev_list, $blame_dict) = $queries[$path]->getBlameData();
|
|
foreach (array_keys($this->blame[$path]) as $line) {
|
|
$commit_identifier = $rev_list[$line - 1];
|
|
$author = idx($blame_dict[$commit_identifier], 'authorPHID');
|
|
if ($author) {
|
|
$authors[$author][$path][] = $line;
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($authors) {
|
|
$this->conn->openTransaction();
|
|
|
|
foreach ($authors as $author => $paths) {
|
|
$where = array();
|
|
foreach ($paths as $path => $lines) {
|
|
$where[] = qsprintf(
|
|
$this->conn,
|
|
'(path = %s AND line IN (%Ld))',
|
|
$this->svnRoot.'/'.$path,
|
|
$lines);
|
|
}
|
|
queryfx(
|
|
$this->conn,
|
|
'UPDATE %T SET authorPHID = %s WHERE %Q',
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
$author,
|
|
implode(' OR ', $where));
|
|
}
|
|
|
|
$this->conn->saveTransaction();
|
|
}
|
|
}
|
|
|
|
}
|