1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/maniphest
epriestley 1dfa94e571 Use binary collations for most text
Summary:
Ref T1191. For most text columns, we either don't care if "a" and "A" are the same, or we expect them to be different (for example: keys, domains, secrets, etc). Default text columns to the `_bin` collation so they are compared by strict character value. This is safer in cases where we aren't sure.

For some text columns, we allow the user to sort by the column in the UI (like Maniphest task titles) or we do care that "A" and "a" are the same (for example: project names). Introduce a new class of virtual data types, the "sort..." types, to cover these columns. These are like the "text..." types but use sorting collations which treat "A" and "a" the same.

Test Plan:
  - Made an effort to identify all columns where the UI relies on database collation.
  - Ran `bin/storage adjust` and cleared all warnings.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: beng, epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10602
2014-10-01 08:18:53 -07:00
..
application Rename policy capabilities 2014-07-25 08:20:39 +10:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit allow setting view and edit policy with maniphest.createtask 2014-08-12 14:07:27 -07:00
config Fix confusing documentation on maniphest.default-priority 2014-09-09 09:01:39 -07:00
constants Remove @group annotations 2014-07-10 08:12:48 +10:00
controller Maniphest - always cc the user, including when creating from template 2014-09-03 13:08:52 -07:00
edge Use standard infrastructure to attach commits to other objects 2014-08-04 12:03:58 -07:00
editor Maniphest - upgrade merging to real transactions 2014-09-08 14:17:35 -07:00
event Rename PHIDType classes 2014-07-24 08:05:46 +10:00
export phutil_utf8_shorten => PhutilUTF8StringTruncator 2014-08-29 15:15:13 -07:00
field Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
lipsum Updated PhabricatorManiphestTaskTestDataGenerator to assign projects to the generated tasks. 2014-08-11 13:27:33 -07:00
mail Use transactions properly when building tasks from email 2014-08-12 12:25:47 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Support custom fields in "Order By" for Maniphest 2014-08-02 18:22:16 +10:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Use binary collations for most text 2014-10-01 08:18:53 -07:00
typeahead Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
view Don't render a grip on tasks returned over AJAX to non-draggable UIs 2014-08-16 11:12:43 -07:00