mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-26 00:32:42 +01:00
a89b4ff5b8
Summary: When you visit the Members page of a Parent Subproject, some actions are greyed out by design. And, if you click on them, nothing really useful happens to continue with what you want to do. For example, see this page and click on "Join Project": https://we.phorge.it/project/members/1/ After this change, the interface at least provides a link to proceed to the next step of what you wanted to do - that is - allowing to quickly list direct Subprojects and do something more meaningful than that. A/B for the "Join Project" view: | Before | After | |-----------|-----------| | {F282337} | {F282331} | A/B for the "Add Members" view: | Before | After | |-----------|-----------| | {F282338} | {F282332} | Just to be nice, this change adds some inline documentation on some methods of AphrontDialogView used here. Closes T15258 Test Plan: - Create a Project (A) with a Subproject (B) - Visit Members page of (A) - Click on Join Project and click on the Blue Button - Click on the Add Member and click on Blue Button - in both cases it should get you to Subprojects list Reviewers: O1 Blessed Committers, Matthew Reviewed By: O1 Blessed Committers, Matthew Subscribers: speck, tobiaswiese, Matthew, Cigaryno Maniphest Tasks: T15258 Differential Revision: https://we.phorge.it/D25127 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| aphront | ||
| applications | ||
| docs | ||
| extensions | ||
| infrastructure | ||
| view | ||
| __phutil_library_init__.php | ||
| __phutil_library_map__.php | ||