mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 09:12:41 +01:00
fb9d036e57
Summary: Does the UI work that's part of T12234 and adds migrations for both of the old-style duplicate transactions. Test Plan: - Started with a clean DB. - Checked out really old code that marks tasks as dupes using comments. - Made a bunch of tasks and closed some as dupes. Made a bunch of additional comments. - Checked out D10427 and did a `storage upgrade`. - Made a bunch more new tasks and dupes. - Snapshotted DB. - Ran migration repeatedly until all expected edges showed up in the `phabricator_maniphest.edge`table. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T12234 Differential Revision: https://secure.phabricator.com/D18037
68 lines
2 KiB
PHP
68 lines
2 KiB
PHP
<?php
|
|
|
|
$table = new ManiphestTransaction();
|
|
$add_edges = array();
|
|
|
|
foreach (new LiskMigrationIterator($table) as $txn) {
|
|
$txn_type = $txn->getTransactionType();
|
|
|
|
if ($txn_type == 'mergedinto') {
|
|
// dupe handling as implemented in D10427, which creates a specific txn
|
|
$add_edges[] = array(
|
|
'src' => $txn->getObjectPHID(),
|
|
'dst' => $txn->getNewValue(),
|
|
);
|
|
} else if ($txn_type == 'status' && $txn->getNewValue() == 'duplicate') {
|
|
// dupe handling as originally implemented, which just changes the status
|
|
// and adds a comment
|
|
$src_phid = $txn->getObjectPHID();
|
|
|
|
// get all the comment transactions associated with this task
|
|
$viewer = PhabricatorUser::getOmnipotentUser();
|
|
$comment_txns = id(new ManiphestTransactionQuery())
|
|
->setViewer($viewer)
|
|
->withObjectPHIDs(array($src_phid))
|
|
->needComments(true)
|
|
->execute();
|
|
|
|
// check each comment, looking for the "Merged Into" message
|
|
foreach ($comment_txns as $comment_txn) {
|
|
if ($comment_txn->hasComment()) {
|
|
$comment = $comment_txn->getComment()->getContent();
|
|
$pattern = '/^\xE2\x9C\x98 Merged into T(\d+)\.$/';
|
|
$matches = array();
|
|
|
|
if (preg_match($pattern, $comment, $matches)) {
|
|
$dst_task = id(new ManiphestTaskQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($matches[1]))
|
|
->executeOne();
|
|
|
|
if ($dst_task) {
|
|
$dst_phid = $dst_task->getPHID();
|
|
$add_edges[] = array(
|
|
'src' => $src_phid,
|
|
'dst' => $dst_phid,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($add_edges) {
|
|
foreach ($add_edges as $edge) {
|
|
$src_phid = $edge['src'];
|
|
$dst_phid = $edge['dst'];
|
|
|
|
$type = ManiphestTaskIsDuplicateOfTaskEdgeType::EDGECONST;
|
|
try {
|
|
$editor = id(new PhabricatorEdgeEditor())
|
|
->addEdge($src_phid, $type, $dst_phid)
|
|
->save();
|
|
} catch (PhabricatorEdgeCycleException $ex) {
|
|
// Some earlier or later merge made this invalid, just skip it.
|
|
}
|
|
}
|
|
}
|